Bug 240243

Summary: TestAPI::promiseUnhandledRejection() predominantly fails on MacOS 12.3 in --debug
Product: WebKit Reporter: Truitt Savell <tsavell>
Component: Tools / TestsAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ashvayka, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bot-watchers-bugzilla, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Mac (Apple Silicon)   
OS: macOS 12   
See Also: https://bugs.webkit.org/show_bug.cgi?id=161942
Attachments:
Description Flags
Patch
none
Patch for landing ashvayka: commit-queue-

Truitt Savell
Reported 2022-05-09 11:25:39 PDT
testapi This test is flaky failing for a long time in history. I do not have a regression point. History: https://results.webkit.org/?suite=javascriptcore-tests&test=testapi build: https://build.webkit.org/#/builders/378/builds/1036
Attachments
Patch (2.19 KB, patch)
2022-05-23 15:16 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.21 KB, patch)
2022-05-24 11:15 PDT, Alexey Shvayka 		ashvayka: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-05-09 11:26:03 PDT
<rdar://problem/92975620>
Alexey Proskuryakov
Comment 2 2022-05-09 13:45:01 PDT
I'm not entirely sure how to interpret testapi output, but looks like there is more that one failure: callback should receive rejected promise as first argument: FAILED callback should receive rejection reason as second argument: FAILED callback should not receive a third argument: PASSED C-API tests in C++ had 2 failures ASSERTION FAILED: !testCAPIViaCpp(filter) /Volumes/Data/worker/Apple-Monterey-Debug-Build/build/Source/JavaScriptCore/API/tests/testapi.c(1409) : int main(int, char **) 1 0x112cb4ab0 WTFCrash 2 0x100823f80 main 3 0x100ced088
Mark Lam
Comment 3 2022-05-09 14:34:48 PDT
I've also seen this fail intermittently on a Release build on M1 (when testapi is run while some heavy load is running in the background like a WebKit build). I've never seen it on a Debug build yet.
Ryan Haddad
Comment 4 2022-05-23 09:18:07 PDT
*** Bug 240804 has been marked as a duplicate of this bug. ***
Alexey Shvayka
Comment 5 2022-05-23 15:16:53 PDT
Created attachment 459688 [details] Patch
Mark Lam
Comment 6 2022-05-23 16:09:05 PDT
Comment on attachment 459688 [details] Patch LGTM
Alexey Shvayka
Comment 7 2022-05-24 11:15:36 PDT
Created attachment 459728 [details] Patch for landing
Mark Lam
Comment 8 2022-05-24 16:51:45 PDT
https://github.com/WebKit/WebKit/pull/989
EWS
Comment 9 2022-05-25 11:14:00 PDT
Committed r294811 (250965@main): <https://commits.webkit.org/250965@main> Reviewed commits have been landed. Closing PR #989 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.