Bug 240220

Summary:

[WebGPU] Make the first few buffer mapping tests pass

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

WebGPU

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

ASSIGNED

Severity:

Normal

CC:

cdumez, esprehn+autocc, ews-watchlist, kondapallykalyan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

240441

Bug Blocks:

240435, 240436, 240437, 240438

Attachments:

Description	Flags
WIP	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none

Myles C. Maxfield

Reported 2022-05-08 17:34:24 PDT

Attachments
WIP (11.47 KB, patch) 2022-05-08 17:34 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (12.54 KB, patch) 2022-05-08 23:10 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (168.96 KB, patch) 2022-05-15 14:50 PDT, Myles C. Maxfield	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (166.29 KB, patch) 2022-05-15 18:50 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2022-05-08 17:34:49 PDT

Created attachment 459018 [details] WIP

Myles C. Maxfield

Comment 2 2022-05-08 23:10:14 PDT

Created attachment 459028 [details] Patch

Myles C. Maxfield

Comment 3 2022-05-08 23:16:44 PDT

Comment on attachment 459028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459028&action=review > Source/WebGPU/WebGPU/Buffer.mm:212 > + ASSERT(m_buffer.contents); We probably need some kind of zero-filling logic. Mapping a buffer for write is supposed to zero-fill it, if JS actually ends up reading the ArrayBuffer.

Myles C. Maxfield

Comment 4 2022-05-08 23:40:25 PDT

Oh, mapping a buffer for reading on discrete GPU systems requires a call to synchronizeResource().

Myles C. Maxfield

Comment 5 2022-05-08 23:45:40 PDT

What if JavaScript specifies the sentinel?

Myles C. Maxfield

Comment 6 2022-05-15 14:50:13 PDT

Created attachment 459384 [details] Patch

Radar WebKit Bug Importer

Comment 7 2022-05-15 17:35:13 PDT

<rdar://problem/93318423>