| Summary: | Fix adattributiond build in internal build on older macOS | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, emw, mmaxfield, msaboff, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2022-05-06 14:19:46 PDT
Created attachment 458974 [details]
Patch
Comment on attachment 458974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458974&action=review > Source/WebKit/Configurations/adattributiond.xcconfig:24 > +#include "Base.xcconfig" This is not necessary, please remove. Xcode project includes either Base.xcconfing or DebugRelease.xcconfig for all projects. CC'ing some people who recently made similar changes, and would have a keener eye than myself. This looks like an improvement, but I'm uncertain if this covers all other cases besides StagedFrameworks, like Safari Tech Preview. Comment on attachment 458974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458974&action=review >> Source/WebKit/Configurations/adattributiond.xcconfig:24 >> +#include "Base.xcconfig" > > This is not necessary, please remove. Xcode project includes either Base.xcconfing or DebugRelease.xcconfig for all projects. I verified this is not needed. Will remove. Created attachment 458979 [details]
Patch
Committed r293936 (250382@main): <https://commits.webkit.org/250382@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458979 [details]. https://bugs.webkit.org/show_bug.cgi?id=240201 fixes some fallout from this. |