Bug 240063

Summary: [Mac] WebCore should search system content path for nested Frameworks
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: PlatformAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, david_quesada, emw, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ap: review+, ap: commit-queue-
Patch for Landing none

Michael Saboff
Reported 2022-05-04 07:02:40 PDT
We building with the system content path, we should search there for the WebCore nested frameworks instead of the symlinked location.
Attachments
Patch (1.95 KB, patch)
2022-05-04 07:20 PDT, Michael Saboff 		ap: review+
ap: commit-queue-
DetailsFormatted DiffDiff
Patch for Landing (2.18 KB, patch)
2022-05-04 11:17 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2022-05-04 07:02:51 PDT
<rdar://92426000>
Michael Saboff
Comment 2 2022-05-04 07:20:58 PDT
Created attachment 458791 [details] Patch
Elliott Williams
Comment 3 2022-05-04 09:56:52 PDT
Comment on attachment 458791 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458791&action=review r=me > Source/WebCore/Configurations/WebCore.xcconfig:66 > WK_FRAMEWORKS_LIBRARY_DIR_USE_ALTERNATE_FRAMEWORKS_DIR_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks/WebCore.framework/Versions/A/Frameworks; Do we want $(INSTALL_PATH_PREFIX) here too? I believe this path is used for catalyst builds, where WK_ALTERNATE_FRAMEWORKS_DIR = /System/iOSSupport.
Alexey Proskuryakov
Comment 4 2022-05-04 10:24:18 PDT
Comment on attachment 458791 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458791&action=review >> Source/WebCore/Configurations/WebCore.xcconfig:66 >> WK_FRAMEWORKS_LIBRARY_DIR_USE_ALTERNATE_FRAMEWORKS_DIR_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks/WebCore.framework/Versions/A/Frameworks; > > Do we want $(INSTALL_PATH_PREFIX) here too? I believe this path is used for catalyst builds, where WK_ALTERNATE_FRAMEWORKS_DIR = /System/iOSSupport. Great catch, I think that we need the same change for macCatalyst too. Surprised that building with the patch didn't fail macCatalyst build.
Michael Saboff
Comment 5 2022-05-04 10:45:22 PDT
(In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 458791 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=458791&action=review > > >> Source/WebCore/Configurations/WebCore.xcconfig:66 > >> WK_FRAMEWORKS_LIBRARY_DIR_USE_ALTERNATE_FRAMEWORKS_DIR_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks/WebCore.framework/Versions/A/Frameworks; > > > > Do we want $(INSTALL_PATH_PREFIX) here too? I believe this path is used for catalyst builds, where WK_ALTERNATE_FRAMEWORKS_DIR = /System/iOSSupport. > > Great catch, I think that we need the same change for macCatalyst too. > Surprised that building with the patch didn't fail macCatalyst build. Added. Running a local macCatalyst build to verify.
Michael Saboff
Comment 6 2022-05-04 11:17:24 PDT
Created attachment 458814 [details] Patch for Landing
EWS
Comment 7 2022-05-04 14:56:59 PDT
Committed r293794 (250268@main): <https://commits.webkit.org/250268@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458814 [details].
Note You need to log in before you can comment on or make changes to this bug.