Bug 239900

Summary: Add WebKit API to turn off the URL scheme check when linkifying through Data Detectors
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ggaren: review+
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Per Arne Vollan
Reported 2022-04-29 08:04:49 PDT
Add WebKit API to turn off the URL scheme check when linkifying through Data Detectors. This will enable us to block the Mach service com.apple.lsd.open in the WebContent process for all clients.
Attachments
Patch (13.74 KB, patch)
2022-04-29 08:16 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (13.80 KB, patch)
2022-04-29 09:18 PDT, Per Arne Vollan 		ggaren: review+
DetailsFormatted DiffDiff
Patch (14.10 KB, patch)
2022-05-11 15:54 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (16.49 KB, patch)
2022-05-16 11:56 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (15.91 KB, patch)
2022-05-17 08:25 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (15.92 KB, patch)
2022-05-17 10:28 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2022-04-29 08:16:11 PDT
Created attachment 458587 [details] Patch
Per Arne Vollan
Comment 2 2022-04-29 09:17:44 PDT
<rdar://92026172>
Per Arne Vollan
Comment 3 2022-04-29 09:18:34 PDT
Created attachment 458591 [details] Patch
Geoffrey Garen
Comment 4 2022-04-29 15:53:06 PDT
Comment on attachment 458591 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458591&action=review > Source/WebKit/ChangeLog:10 > + The URL scheme check is disabled by default for all clients that are not Web browsers. Probably worth a ChangeLog comment explaining why we made this default choice. Come to think of it, why did we make this default choice? I guess our motivating example was Mail clients? Maybe we should enable by default just for apps with the com.apple.developer.mail-client entitlement?
Per Arne Vollan
Comment 5 2022-04-29 16:51:36 PDT
(In reply to Geoffrey Garen from comment #4) > Comment on attachment 458591 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=458591&action=review > > > Source/WebKit/ChangeLog:10 > > + The URL scheme check is disabled by default for all clients that are not Web browsers. > > Probably worth a ChangeLog comment explaining why we made this default > choice. > Will add! > Come to think of it, why did we make this default choice? I guess our > motivating example was Mail clients? Maybe we should enable by default just > for apps with the com.apple.developer.mail-client entitlement? That is a good question. IIRC, we made this choice because we from beforehand knew that com.apple.lsd.open can be blocked for Web browsers, since we already have blocked it there for quite some time without observing any issues. I think we may also have a couple of examples of other apps that are not Mail clients that would need this to be the default behavior. On the other hand, the apps that are not Mail clients could use the new API :) Thanks for reviewing!
Per Arne Vollan
Comment 6 2022-05-11 15:54:18 PDT
Created attachment 459186 [details] Patch
Per Arne Vollan
Comment 7 2022-05-16 09:23:25 PDT
Still holding off landing a bit, since it appears that some builders are not ready yet.
Per Arne Vollan
Comment 8 2022-05-16 11:56:42 PDT
Created attachment 459443 [details] Patch
Per Arne Vollan
Comment 9 2022-05-17 08:25:20 PDT
Created attachment 459499 [details] Patch
Per Arne Vollan
Comment 10 2022-05-17 10:28:25 PDT
Created attachment 459506 [details] Patch
Per Arne Vollan
Comment 11 2022-05-17 14:08:08 PDT
Pull request: https://github.com/WebKit/WebKit/pull/693
EWS
Comment 12 2022-05-18 08:46:42 PDT
Committed r294397 (250691@main): <https://commits.webkit.org/250691@main> Reviewed commits have been landed. Closing PR #693 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.