Bug 239893
| Summary: | ifdef out IPC::MessageName values that aren't applicable | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Cameron McCormack (:heycam) <heycam> |
| Component: | WebKit Process Model | Assignee: | Kimmo Kinnunen <kkinnunen> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Cameron McCormack (:heycam)
IPC::isMessageNameValue's compiled code is kind of complex, since there's bunch of values that return false for particular platforms and ENABLE & USE macros. This function is called for every IPC message. We can make it cheaper by ifdefing out the values in the enum declaration too, and make the function effectively "is messageName >= 1 && messageName <= lastMessageName".
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/92511440>
Kimmo Kinnunen
IPC MessageName validation is slow
- Validated on decoding
- Debug builds validate on encoding
Kimmo Kinnunen
Pull request: https://github.com/WebKit/WebKit/pull/7672
EWS
Committed 258073@main (03178c5e0622): <https://commits.webkit.org/258073@main>
Reviewed commits have been landed. Closing PR #7672 and removing active labels.