Bug 239847

Summary: Make sure to fail importScripts as per https://w3c.github.io/ServiceWorker/#importscripts step 4
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2022-04-28 05:39:44 PDT
Make sure to fail importScripts as per https://w3c.github.io/ServiceWorker/#importscripts step 4
Attachments
Patch (4.82 KB, patch)
2022-04-28 05:41 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2022-04-28 05:41:45 PDT
Created attachment 458519 [details] Patch
Chris Dumez
Comment 2 2022-04-28 10:58:00 PDT
Comment on attachment 458519 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458519&action=review r=me > Source/WebCore/workers/WorkerScriptLoader.cpp:85 > + auto* serviceWorkerGlobalScope = dynamicDowncast<ServiceWorkerGlobalScope>(workerGlobalScope); Would be nice to reduce scoping and do this in the if condition: `if (auto* serviceWorkerGlobalScope = dynamicDowncast<ServiceWorkerGlobalScope>(workerGlobalScope))`
youenn fablet
Comment 3 2022-04-28 23:34:19 PDT
Comment on attachment 458519 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458519&action=review >> Source/WebCore/workers/WorkerScriptLoader.cpp:85 >> + auto* serviceWorkerGlobalScope = dynamicDowncast<ServiceWorkerGlobalScope>(workerGlobalScope); > > Would be nice to reduce scoping and do this in the if condition: > `if (auto* serviceWorkerGlobalScope = dynamicDowncast<ServiceWorkerGlobalScope>(workerGlobalScope))` serviceWorkerGlobalScope is reused below, and it seems a tad better to have a wider scope instead of two casts.
EWS
Comment 4 2022-04-29 00:15:39 PDT
Committed r293607 (250113@main): <https://commits.webkit.org/250113@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458519 [details].
Radar WebKit Bug Importer
Comment 5 2022-04-29 00:16:13 PDT
<rdar://problem/92510321>
Note You need to log in before you can comment on or make changes to this bug.