Bug 239799 – Avoid sending a flush IPC to the GPU process when destroying a RemoteImageBuffer

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Avoid sending a flush IPC to the GPU process when destroying a RemoteImageBuffer

[Simon Fraser (smfr)]

Created attachment 458415 [details]
Patch

[Said Abou-Hallawa]

Comment on attachment 458415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458415&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

This should be removed before landing.

> Source/WebCore/platform/graphics/ImageBuffer.h:101
> +    virtual bool flushDrawingContextAsync() { return false; }

It is not clear from the name what this function returns. Should it be renamed flushDrawingContextAsyncIfNeeded()?

> Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:313
> +        return false;

The order in this function is a little bit hard to read. Can't it be rearranged like this:

// Nothing to flush, return true if we need the caller to wait.
if (!m_remoteDisplayList.needsFlush())
    return hasPendingFlush();

// Do the flushing and tell the caller to wait.
...
m_remoteDisplayList.flushContext(m_sentFlushIdentifier);
...
return true;

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/293522/webkit

[Radar WebKit Bug Importer]

<rdar://problem/92412491>