Bug 239792

Summary: Drop StringImpl::createFromLiteral()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: fujii.hironori, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for landing none

Chris Dumez
Reported 2022-04-26 15:40:59 PDT
Drop StringImpl::createFromLiteral(). Call sites that have an ASCIILiteral can now simply call StringImpl::create(ASCIILiteral). Call sites that have raw characters can call the existing StringImpl::createWithoutCopying(). This simplifies our API a bit.
Attachments
Patch for landing (8.50 KB, patch)
2022-05-05 23:12 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-04-26 16:01:52 PDT
Pull request: https://github.com/WebKit/WebKit/pull/405
EWS
Comment 2 2022-04-29 10:48:33 PDT
Committed r293621 (250127@main): <https://commits.webkit.org/250127@main> Reviewed commits have been landed. Closing PR #405 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-04-29 10:49:13 PDT
<rdar://problem/92532725>
Chris Dumez
Comment 4 2022-04-29 17:52:22 PDT
Reopening since it was temporary reverted to address some internal EWS issues.
Chris Dumez
Comment 5 2022-05-03 19:54:33 PDT
Pull request: https://github.com/WebKit/WebKit/pull/490
EWS
Comment 6 2022-05-04 00:03:46 PDT
Committed r293763 (250242@main): <https://commits.webkit.org/250242@main> Reviewed commits have been landed. Closing PR #490 and removing active labels.
Fujii Hironori
Comment 7 2022-05-05 23:12:54 PDT
Reopening to attach new patch.
Fujii Hironori
Comment 8 2022-05-05 23:12:57 PDT
Created attachment 458934 [details] Patch for landing
EWS
Comment 9 2022-05-06 00:27:19 PDT
Committed r293882 (250340@main): <https://commits.webkit.org/250340@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458934 [details].
Chris Dumez
Comment 10 2022-05-06 07:02:46 PDT
(In reply to Fujii Hironori from comment #7) > Reopening to attach new patch. Thank you for fixing!
Note You need to log in before you can comment on or make changes to this bug.