Bug 239786

Summary: Cannot run test-webkitpy, autoinstaller fails to compile lupa
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: Tools / TestsAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   

Michael Catanzaro
Reported 2022-04-26 13:21:11 PDT
I was trying to run test-webkitpy locally, but noticed that it fails because it attempts to autoinstall lupa, which fails to build. Look at this: Downloading lupa-1.9.0... Installing lupa-1.9.0... No local build of LuaJIT2 found in lupa directory Checking for installed luajit library using pkg-config pkg-config found luajit version 2.1.0-beta3 building without Cython running install running build running build_py creating build creating build/lib.linux-x86_64-3.10 creating build/lib.linux-x86_64-3.10/lupa copying lupa/version.py -> build/lib.linux-x86_64-3.10/lupa copying lupa/__init__.py -> build/lib.linux-x86_64-3.10/lupa running build_ext building 'lupa._lupa' extension creating build/temp.linux-x86_64-3.10 creating build/temp.linux-x86_64-3.10/lupa gcc -Wno-unused-result -Wsign-compare -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DNDEBUG -O2 -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -D_GNU_SOURCE -fPIC -fwrapv -O2 -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -D_GNU_SOURCE -fPIC -fwrapv -O2 -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -D_GNU_SOURCE -fPIC -fwrapv -fPIC -DCYTHON_CLINE_IN_TRACEBACK=0 -I/usr/include/luajit-2.1 -I/usr/include/python3.10 -c lupa/_lupa.c -o build/temp.linux-x86_64-3.10/lupa/_lupa.o lupa/_lupa.c: In function ‘__pyx_pf_4lupa_5_lupa_9FastRLock_6release’: lupa/_lupa.c:3070:38: warning: comparison of integer expressions of different signedness: ‘long int’ and ‘long unsigned int’ [-Wsign-compare] 3070 | __pyx_t_1 = ((__pyx_v_self->_owner != PyThread_get_thread_ident()) != 0); | ^~ lupa/_lupa.c: In function ‘__pyx_pf_4lupa_5_lupa_9FastRLock_10__exit__’: lupa/_lupa.c:3283:38: warning: comparison of integer expressions of different signedness: ‘long int’ and ‘long unsigned int’ [-Wsign-compare] 3283 | __pyx_t_1 = ((__pyx_v_self->_owner != PyThread_get_thread_ident()) != 0); | ^~ lupa/_lupa.c: In function ‘__pyx_pf_4lupa_5_lupa_9FastRLock_12_is_owned’: lupa/_lupa.c:3375:59: warning: comparison of integer expressions of different signedness: ‘long int’ and ‘long unsigned int’ [-Wsign-compare] 3375 | __pyx_t_1 = __Pyx_PyBool_FromLong((__pyx_v_self->_owner == PyThread_get_thread_ident())); if (unlikely(!__pyx_t_1)) __PYX_ERR(1, 55, __pyx_L1_error) | ^~ lupa/_lupa.c: In function ‘__pyx_tp_dealloc_4lupa_5_lupa_FastRLock’: lupa/_lupa.c:27466:5: error: lvalue required as increment operand 27466 | ++Py_REFCNT(o); | ^~ lupa/_lupa.c:27468:5: error: lvalue required as decrement operand 27468 | --Py_REFCNT(o); | ^~ lupa/_lupa.c: In function ‘__pyx_tp_dealloc_4lupa_5_lupa_LuaRuntime’: lupa/_lupa.c:27592:5: error: lvalue required as increment operand 27592 | ++Py_REFCNT(o); | ^~ lupa/_lupa.c:27594:5: error: lvalue required as decrement operand 27594 | --Py_REFCNT(o); | ^~ lupa/_lupa.c: In function ‘__pyx_tp_dealloc_4lupa_5_lupa__LuaObject’: lupa/_lupa.c:27751:5: error: lvalue required as increment operand 27751 | ++Py_REFCNT(o); | ^~ lupa/_lupa.c:27753:5: error: lvalue required as decrement operand 27753 | --Py_REFCNT(o); | ^~ lupa/_lupa.c: In function ‘__pyx_tp_dealloc_4lupa_5_lupa__LuaIter’: lupa/_lupa.c:28496:5: error: lvalue required as increment operand 28496 | ++Py_REFCNT(o); | ^~ lupa/_lupa.c:28498:5: error: lvalue required as decrement operand 28498 | --Py_REFCNT(o); | ^~ lupa/_lupa.c: In function ‘__Pyx_ParseOptionalKeywords’: lupa/_lupa.c:31674:21: warning: ‘_PyUnicode_get_wstr_length’ is deprecated [-Wdeprecated-declarations] 31674 | (PyUnicode_GET_SIZE(**name) != PyUnicode_GET_SIZE(key)) ? 1 : | ^ In file included from /usr/include/python3.10/unicodeobject.h:1046, from /usr/include/python3.10/Python.h:83, from lupa/_lupa.c:33: /usr/include/python3.10/cpython/unicodeobject.h:446:26: note: declared here 446 | static inline Py_ssize_t _PyUnicode_get_wstr_length(PyObject *op) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~ lupa/_lupa.c:31674:21: warning: ‘PyUnicode_AsUnicode’ is deprecated [-Wdeprecated-declarations] 31674 | (PyUnicode_GET_SIZE(**name) != PyUnicode_GET_SIZE(key)) ? 1 : | ^ /usr/include/python3.10/cpython/unicodeobject.h:580:45: note: declared here 580 | Py_DEPRECATED(3.3) PyAPI_FUNC(Py_UNICODE *) PyUnicode_AsUnicode( | ^~~~~~~~~~~~~~~~~~~ lupa/_lupa.c:31674:21: warning: ‘_PyUnicode_get_wstr_length’ is deprecated [-Wdeprecated-declarations] 31674 | (PyUnicode_GET_SIZE(**name) != PyUnicode_GET_SIZE(key)) ? 1 : | ^ /usr/include/python3.10/cpython/unicodeobject.h:446:26: note: declared here 446 | static inline Py_ssize_t _PyUnicode_get_wstr_length(PyObject *op) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~ lupa/_lupa.c:31674:21: warning: ‘_PyUnicode_get_wstr_length’ is deprecated [-Wdeprecated-declarations] 31674 | (PyUnicode_GET_SIZE(**name) != PyUnicode_GET_SIZE(key)) ? 1 : | ^ /usr/include/python3.10/cpython/unicodeobject.h:446:26: note: declared here 446 | static inline Py_ssize_t _PyUnicode_get_wstr_length(PyObject *op) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~ lupa/_lupa.c:31674:21: warning: ‘PyUnicode_AsUnicode’ is deprecated [-Wdeprecated-declarations] 31674 | (PyUnicode_GET_SIZE(**name) != PyUnicode_GET_SIZE(key)) ? 1 : | ^ /usr/include/python3.10/cpython/unicodeobject.h:580:45: note: declared here 580 | Py_DEPRECATED(3.3) PyAPI_FUNC(Py_UNICODE *) PyUnicode_AsUnicode( | ^~~~~~~~~~~~~~~~~~~ lupa/_lupa.c:31674:21: warning: ‘_PyUnicode_get_wstr_length’ is deprecated [-Wdeprecated-declarations] 31674 | (PyUnicode_GET_SIZE(**name) != PyUnicode_GET_SIZE(key)) ? 1 : | ^ /usr/include/python3.10/cpython/unicodeobject.h:446:26: note: declared here 446 | static inline Py_ssize_t _PyUnicode_get_wstr_length(PyObject *op) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~ lupa/_lupa.c:31690:25: warning: ‘_PyUnicode_get_wstr_length’ is deprecated [-Wdeprecated-declarations] 31690 | (PyUnicode_GET_SIZE(**argname) != PyUnicode_GET_SIZE(key)) ? 1 : | ^ /usr/include/python3.10/cpython/unicodeobject.h:446:26: note: declared here 446 | static inline Py_ssize_t _PyUnicode_get_wstr_length(PyObject *op) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~ lupa/_lupa.c:31690:25: warning: ‘PyUnicode_AsUnicode’ is deprecated [-Wdeprecated-declarations] 31690 | (PyUnicode_GET_SIZE(**argname) != PyUnicode_GET_SIZE(key)) ? 1 : | ^ /usr/include/python3.10/cpython/unicodeobject.h:580:45: note: declared here 580 | Py_DEPRECATED(3.3) PyAPI_FUNC(Py_UNICODE *) PyUnicode_AsUnicode( | ^~~~~~~~~~~~~~~~~~~ lupa/_lupa.c:31690:25: warning: ‘_PyUnicode_get_wstr_length’ is deprecated [-Wdeprecated-declarations] 31690 | (PyUnicode_GET_SIZE(**argname) != PyUnicode_GET_SIZE(key)) ? 1 : | ^ /usr/include/python3.10/cpython/unicodeobject.h:446:26: note: declared here 446 | static inline Py_ssize_t _PyUnicode_get_wstr_length(PyObject *op) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~ lupa/_lupa.c:31690:25: warning: ‘_PyUnicode_get_wstr_length’ is deprecated [-Wdeprecated-declarations] 31690 | (PyUnicode_GET_SIZE(**argname) != PyUnicode_GET_SIZE(key)) ? 1 : | ^ /usr/include/python3.10/cpython/unicodeobject.h:446:26: note: declared here 446 | static inline Py_ssize_t _PyUnicode_get_wstr_length(PyObject *op) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~ lupa/_lupa.c:31690:25: warning: ‘PyUnicode_AsUnicode’ is deprecated [-Wdeprecated-declarations] 31690 | (PyUnicode_GET_SIZE(**argname) != PyUnicode_GET_SIZE(key)) ? 1 : | ^ /usr/include/python3.10/cpython/unicodeobject.h:580:45: note: declared here 580 | Py_DEPRECATED(3.3) PyAPI_FUNC(Py_UNICODE *) PyUnicode_AsUnicode( | ^~~~~~~~~~~~~~~~~~~ lupa/_lupa.c:31690:25: warning: ‘_PyUnicode_get_wstr_length’ is deprecated [-Wdeprecated-declarations] 31690 | (PyUnicode_GET_SIZE(**argname) != PyUnicode_GET_SIZE(key)) ? 1 : | ^ /usr/include/python3.10/cpython/unicodeobject.h:446:26: note: declared here 446 | static inline Py_ssize_t _PyUnicode_get_wstr_length(PyObject *op) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~ lupa/_lupa.c: In function ‘__Pyx_decode_c_string’: lupa/_lupa.c:31954:9: warning: ‘PyUnicode_FromUnicode’ is deprecated [-Wdeprecated-declarations] 31954 | return PyUnicode_FromUnicode(NULL, 0); | ^~~~~~ /usr/include/python3.10/cpython/unicodeobject.h:551:42: note: declared here 551 | Py_DEPRECATED(3.3) PyAPI_FUNC(PyObject*) PyUnicode_FromUnicode( | ^~~~~~~~~~~~~~~~~~~~~ lupa/_lupa.c: In function ‘__Pyx_decode_c_bytes’: lupa/_lupa.c:33605:9: warning: ‘PyUnicode_FromUnicode’ is deprecated [-Wdeprecated-declarations] 33605 | return PyUnicode_FromUnicode(NULL, 0); | ^~~~~~ /usr/include/python3.10/cpython/unicodeobject.h:551:42: note: declared here 551 | Py_DEPRECATED(3.3) PyAPI_FUNC(PyObject*) PyUnicode_FromUnicode( | ^~~~~~~~~~~~~~~~~~~~~ error: command '/usr/bin/gcc' failed with exit code 1 Failed to install lupa-1.9.0! Traceback (most recent call last): File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/test/main.py", line 365, in <module> sys.exit(main()) File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/test/main.py", line 114, in main return not tester.run() File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/test/main.py", line 187, in run return self._run_tests(names) File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/test/main.py", line 200, in _run_tests AutoInstall.install_everything() File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py", line 612, in install_everything package.install() File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py", line 313, in install subprocess.check_call( File "/usr/lib64/python3.10/subprocess.py", line 369, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['/usr/bin/python3', '/tmp/lupa/lupa-1.9/setup.py', 'install', '--home=/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64', '--root=/', '--prefix=', '--install-lib=/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64', '--install-scripts=/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/bin', '--install-data=/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/data', '--install-headers=/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/headers']' returned non-zero exit status 1. This can be fixed by simply updating to a newer version of lupa.
Attachments
Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2022-04-26 14:00:20 PDT
https://github.com/WebKit/WebKit/pull/400
EWS
Comment 2 2022-04-26 16:39:47 PDT
Committed r293483 (250017@main): <https://commits.webkit.org/250017@main> Reviewed commits have been landed. Closing PR #400 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-04-26 16:40:14 PDT
<rdar://problem/92366063>
Note You need to log in before you can comment on or make changes to this bug.