Bug 239760

Summary: PlatformDisplay::PlatformDisplay(GdkDisplay* display) does not set m_eglDisplay to EGL_NO_DISPLAY
Product: WebKit Reporter: Xi Ruoyao <xry111>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro
Priority: P2    
Version: WebKit Local Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Xi Ruoyao
Reported 2022-04-26 00:40:27 PDT
The value of PlatformDisplay::m_eglDisplay is left with a random value, then triggers EGLDisplay Initialization failed: EGL_BAD_DISPLAY in PlatformDisplay::initializeEGLDisplay.
Attachments
Patch (1.58 KB, patch)
2022-04-26 05:05 PDT, Xi Ruoyao 		no flags
DetailsFormatted DiffDiff
Patch (1.52 KB, patch)
2022-04-26 08:40 PDT, Xi Ruoyao 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xi Ruoyao
Comment 1 2022-04-26 05:05:42 PDT
Created attachment 458354 [details] Patch
Michael Catanzaro
Comment 2 2022-04-26 08:30:58 PDT
Comment on attachment 458354 [details] Patch Oops. This change looks safe and good. But could you please use the initializer list, as in the constructor above?
Xi Ruoyao
Comment 3 2022-04-26 08:40:40 PDT
Created attachment 458371 [details] Patch
Xi Ruoyao
Comment 4 2022-04-26 08:44:20 PDT
(In reply to Michael Catanzaro from comment #2) > Comment on attachment 458354 [details] > Patch > > Oops. > > This change looks safe and good. But could you please use the initializer > list, as in the constructor above? Updated. I initially didn't like a "," leading the line but now I've found out WebKit widely uses initializer lists with such a format.
EWS
Comment 5 2022-04-26 11:52:36 PDT
Committed r293441 (249996@main): <https://commits.webkit.org/249996@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458371 [details].
Note You need to log in before you can comment on or make changes to this bug.