Bug 239755

Summary: Ensure completion handler is called in SWServer::clear
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: Service WorkersAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Sihui Liu
Reported 2022-04-25 21:39:38 PDT
...
Attachments
Patch (2.08 KB, patch)
2022-04-25 21:40 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.13 KB, patch)
2022-04-27 14:10 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2022-04-25 21:40:52 PDT
Created attachment 458325 [details] Patch
youenn fablet
Comment 2 2022-04-26 07:42:05 PDT
Comment on attachment 458325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458325&action=review > Source/WebCore/workers/service/server/SWServer.cpp:348 > + if (m_registrationStore) { I would reverse the check, something like: if (! m_registrationStore) { completionHandler(); return; }
Sihui Liu
Comment 3 2022-04-27 14:09:59 PDT
Comment on attachment 458325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458325&action=review >> Source/WebCore/workers/service/server/SWServer.cpp:348 >> + if (m_registrationStore) { > > I would reverse the check, something like: > if (! m_registrationStore) { completionHandler(); return; } Sure, will change.
Sihui Liu
Comment 4 2022-04-27 14:10:50 PDT
Created attachment 458466 [details] Patch for landing
EWS
Comment 5 2022-04-27 19:05:07 PDT
Committed r293550 (250070@main): <https://commits.webkit.org/250070@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458466 [details].
Radar WebKit Bug Importer
Comment 6 2022-04-27 19:06:14 PDT
<rdar://problem/92433826>
Note You need to log in before you can comment on or make changes to this bug.