Bug 239728

Summary:	Introduce new makeStringByReplacingAll(StringView, UChar, UChar) function
Product:	WebKit	Reporter:	Chris Dumez <cdumez>
Component:	Web Template Framework	Assignee:	Chris Dumez <cdumez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	darin, ggaren, sam, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Chris Dumez

Reported 2022-04-25 09:42:07 PDT

Introduce new makeStringByReplacingAll(StringView, UChar, UChar) function, to complement the existing makeStringByReplacingAll(const String&, UChar, UChar). This allows several call sites from avoiding a temporary String constructing since they have a StringView.

Attachments
Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2022-04-25 10:04:22 PDT

Pull request: https://github.com/WebKit/WebKit/pull/378

EWS

Comment 2 2022-04-25 17:12:50 PDT

Committed r293379 (249969@main): <https://commits.webkit.org/249969@main> Reviewed commits have been landed. Closing PR #378 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2022-04-25 17:13:17 PDT

<rdar://problem/92303369>

Note You need to log in before you can comment on or make changes to this bug.