Bug 239680

Summary: Reduce sizeof(CSSNumericType)
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2022-04-22 18:03:21 PDT
Reduce sizeof(CSSNumericType)
Attachments
Patch (5.00 KB, patch)
2022-04-22 18:03 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2022-04-22 18:03:54 PDT
Created attachment 458191 [details] Patch
Yusuke Suzuki
Comment 2 2022-04-22 18:07:58 PDT
Comment on attachment 458191 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458191&action=review > Source/WebCore/css/typedom/numeric/CSSNumericType.h:39 > + using BaseTypeStorage = Markable<int, IntegralMarkableTraits<int, std::numeric_limits<int>::min()>>; We handle INT_MIN as nullopt value, is it correct for these types? If it is ok, then r=me.
Alex Christensen
Comment 3 2022-04-22 18:13:50 PDT
Comment on attachment 458191 [details] Patch In practice most of these values will just be 1 or nullopt, the consequence of hitting INT_MIN are understandable, and the memory wins are worth it in my opinion.
EWS
Comment 4 2022-04-22 19:16:25 PDT
Committed r293278 (249908@main): <https://commits.webkit.org/249908@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458191 [details].
Radar WebKit Bug Importer
Comment 5 2022-04-22 19:17:14 PDT
<rdar://problem/92201729>
Note You need to log in before you can comment on or make changes to this bug.