| Summary: | Fix build error caused by LTO + Unified Sources | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Justin Michaud <justin_michaud> | ||||
| Component: | New Bugs | Assignee: | Justin Michaud <justin_michaud> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, dino, ews-watchlist, kondapallykalyan, mark.lam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Justin Michaud
2022-04-22 17:43:00 PDT
Created attachment 458189 [details]
Patch
Comment on attachment 458189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458189&action=review rs=me ... too > Source/WebCore/ChangeLog:3 > + Fix build error caused by LTO + Unified Sources nit: We'll typically say something like "Speculative fix for build error caused by LTO + Unified Sources" so that reviewers will know that the fix is of a speculative nature. I confirmed that this fixes the build error. I'll give Mac-debug another shot to run and then merge. Mac-debug timing out appears to be a known issue, landing. Committed r293295 (249920@main): <https://commits.webkit.org/249920@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458189 [details]. |