Bug 239654

Summary: [LFC][Integration] Add FlexFormattingContextIntegrationEnabled setting
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, sam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

zalan
Reported 2022-04-22 07:45:03 PDT
ssia
Attachments
Patch (7.80 KB, patch)
2022-04-22 07:56 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (6.44 KB, patch)
2022-04-22 09:38 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-04-22 07:56:50 PDT
Created attachment 458148 [details] Patch
Antti Koivisto
Comment 2 2022-04-22 08:25:07 PDT
Comment on attachment 458148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458148&action=review > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:310 > + webcoreBinding: RuntimeEnabledFeatures I know the existing LFC flags are RuntimeEnabledFeatures but I wonder if this needs to be. I think they are disfavoured for some reason.
zalan
Comment 3 2022-04-22 09:38:25 PDT
Created attachment 458153 [details] Patch
Simon Fraser (smfr)
Comment 4 2022-04-22 10:15:47 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 458148 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=458148&action=review > > > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:310 > > + webcoreBinding: RuntimeEnabledFeatures > > I know the existing LFC flags are RuntimeEnabledFeatures but I wonder if > this needs to be. I think they are disfavoured for some reason. Because RuntimeEnabledFeatures are per web process but the UI makes it look like it behaves like a per-Page thing, so stuff breaks when there is > 1 Page per process.
EWS
Comment 5 2022-04-22 11:26:30 PDT
Committed r293233 (249897@main): <https://commits.webkit.org/249897@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458153 [details].
Radar WebKit Bug Importer
Comment 6 2022-04-22 11:27:14 PDT
<rdar://problem/92178248>
Note You need to log in before you can comment on or make changes to this bug.