Bug 239641

Summary: Bail out from text decoration computation if none is requested
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, ntim, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Antti Koivisto
Reported 2022-04-22 01:21:15 PDT
We look for them unnecessarily.
Attachments
Patch (2.64 KB, patch)
2022-04-22 01:26 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.06 KB, patch)
2022-04-22 03:54 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2022-04-22 01:26:37 PDT
Created attachment 458120 [details] Patch
Tim Nguyen (:ntim)
Comment 2 2022-04-22 03:09:42 PDT
Comment on attachment 458120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458120&action=review > Source/WebCore/rendering/TextDecorationPainter.cpp:413 > + if (requestedDecorations.isEmpty()) > + return { }; Can we use the same more strict check like above? or does that cause issues? Fwiw, blink isn't supported, and none should do nothing.
Antti Koivisto
Comment 3 2022-04-22 03:54:01 PDT
Created attachment 458134 [details] Patch for landing
Antti Koivisto
Comment 4 2022-04-22 03:55:14 PDT
> Can we use the same more strict check like above? or does that cause issues? > Fwiw, blink isn't supported, and none should do nothing. Good point, though I went to other directions by just using isEmpty(). I also removed the unused None value.
EWS
Comment 5 2022-04-22 05:03:27 PDT
Committed r293217 (249886@main): <https://commits.webkit.org/249886@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458134 [details].
Radar WebKit Bug Importer
Comment 6 2022-04-22 05:04:14 PDT
<rdar://problem/92157483>
Note You need to log in before you can comment on or make changes to this bug.