Bug 23952

Summary: Refactor so that Document::write is funnel method again for all document.write
Product: WebKit Reporter: Adam Treat <manyoso>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Attachments:
Description Flags
Refactor patch darin: review+

Adam Treat
Reported 2009-02-13 10:13:34 PST
In r40976 a change was made to speedup document.write from JS. With the change Document::write was effectively implemented in two places: in Document.cpp and in JSHTMLDocumentCustom.cpp. This patch refactors so that Document::write is the funnel method again, but keeps the speedup. Cheers, Adam
Attachments
Refactor patch (4.07 KB, patch)
2009-02-13 10:14 PST, Adam Treat 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Treat
Comment 1 2009-02-13 10:14:24 PST
Created attachment 27664 [details] Refactor patch
Adam Treat
Comment 2 2009-02-13 10:15:58 PST
I've also removed Document::pendingWrite since it is no longer needed with this patch.
Darin Adler
Comment 3 2009-02-13 11:46:29 PST
Comment on attachment 27664 [details] Refactor patch Seems fine. r=me
Darin Adler
Comment 4 2009-02-13 11:46:51 PST
Does this compile on all platforms?
Adam Treat
Comment 5 2009-02-13 12:50:23 PST
I can only compile it on Qt, but I have compiled and tested and it works for Qt.
Adam Treat
Comment 6 2009-02-13 13:02:14 PST
Landed with r40988.
Darin Adler
Comment 7 2009-02-13 14:30:24 PST
I missed the fact that this leaves an extra if statement in Document::write. Currently it checks m_tokenizer for 0 twice in a row.
Adam Treat
Comment 8 2009-02-13 14:45:30 PST
I'll remove that. Sorry.
Adam Treat
Comment 9 2009-02-13 14:50:12 PST
Fixed with r40992.
Note You need to log in before you can comment on or make changes to this bug.