Bug 239514

Summary:

Implement `auto` value as a computed value for `user-select` and stop making it inherited

Product:

WebKit

Reporter:

Tim Nguyen (:ntim) <ntim>

Component:

CSS

Assignee:

Tim Nguyen (:ntim) <ntim>

Status:

NEW

Severity:

Normal

CC:

changseok, emilio, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, joepeck, kondapallykalyan, macpherson, menard, pdr, philipj, sergio, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

208677

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-

Tim Nguyen (:ntim)

Reported 2022-04-19 12:08:00 PDT

user-select: auto should compute to `user-select: auto` not `text` `user-select` also isn't an inherited property, the `auto` should take care of the "inheritance".

Attachments
Patch (22.04 KB, patch) 2022-04-21 02:51 PDT, Tim Nguyen (:ntim)	no flags	Details Formatted Diff Diff
Patch (22.03 KB, patch) 2022-04-21 02:53 PDT, Tim Nguyen (:ntim)	no flags	Details Formatted Diff Diff
Patch (22.04 KB, patch) 2022-04-21 03:43 PDT, Tim Nguyen (:ntim)	no flags	Details Formatted Diff Diff
Patch (22.83 KB, patch) 2022-04-21 06:43 PDT, Tim Nguyen (:ntim)	no flags	Details Formatted Diff Diff
Patch (30.28 KB, patch) 2022-04-22 02:56 PDT, Tim Nguyen (:ntim)	no flags	Details Formatted Diff Diff
Patch (30.32 KB, patch) 2022-04-22 03:38 PDT, Tim Nguyen (:ntim)	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Tim Nguyen (:ntim)

Comment 1 2022-04-19 12:32:01 PDT

Here's how user-select: auto is defined: https://drafts.csswg.org/css-ui-4/#valdef-user-select-auto The used value of auto is determined as follows: * On the ::before and ::after pseudo-elements, the used value is none * If the element is an editable element, the used value is contain * Otherwise, if the used value of user-select on the parent of this element is all, the used value is all * Otherwise, if the used value of user-select on the parent of this element is none, the used value is none * Otherwise, the used value is text > Note: This unusual combination of a non-inherited property with an initial value of auto whose used value depends on the parent element makes it possible to create what is effectively selective inheritance. This was initially proposed by Microsoft in IE to introduce a behavior similar to inheritance except that the contain value does not inherit.

Tim Nguyen (:ntim)

Comment 2 2022-04-21 02:51:27 PDT

Created attachment 458046 [details] Patch

Tim Nguyen (:ntim)

Comment 3 2022-04-21 02:53:53 PDT

Created attachment 458047 [details] Patch

Tim Nguyen (:ntim)

Comment 4 2022-04-21 03:43:58 PDT

Created attachment 458051 [details] Patch

Tim Nguyen (:ntim)

Comment 5 2022-04-21 06:43:44 PDT

Created attachment 458057 [details] Patch