Bug 239476

Summary: [WebXR] Update Device::initializeTrackingAndRendering() to take in more parameters regarding the session setup
Product: WebKit Reporter: Ada Chan <adachan>
Component: New BugsAssignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dino, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ada Chan
Reported 2022-04-18 17:24:06 PDT
[WebXR] Update Device::initializeTrackingAndRendering() to take in more parameters regarding the session setup
Attachments
Patch (17.67 KB, patch)
2022-04-18 17:32 PDT, Ada Chan 		no flags
DetailsFormatted DiffDiff
Patch (17.78 KB, patch)
2022-04-18 20:42 PDT, Ada Chan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2022-04-18 17:32:52 PDT
Created attachment 457845 [details] Patch
Darin Adler
Comment 2 2022-04-18 17:37:06 PDT
Comment on attachment 457845 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457845&action=review > Source/WebKit/Shared/XR/XRDeviceProxy.h:32 > +#include <WebCore/SecurityOriginData.h> Seems like this header could just use a forward declaration of WebCore::SecurityOriginData. The .cpp files can include the header.
Ada Chan
Comment 3 2022-04-18 20:42:20 PDT
Created attachment 457852 [details] Patch
Ada Chan
Comment 4 2022-04-18 20:43:28 PDT
(In reply to Darin Adler from comment #2) > Comment on attachment 457845 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457845&action=review > > > Source/WebKit/Shared/XR/XRDeviceProxy.h:32 > > +#include <WebCore/SecurityOriginData.h> > > Seems like this header could just use a forward declaration of > WebCore::SecurityOriginData. The .cpp files can include the header. Yes! Fixed. Thanks for catching that!
EWS
Comment 5 2022-04-19 13:28:25 PDT
Committed r293033 (249772@main): <https://commits.webkit.org/249772@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457852 [details].
Radar WebKit Bug Importer
Comment 6 2022-04-19 13:29:14 PDT
<rdar://problem/91982150>
Note You need to log in before you can comment on or make changes to this bug.