Bug 239469
| Summary: | Create WebKit review helper Safari extension | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | aperez, ap, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
Yusuke Suzuki
There are several good things to have in GitHub. Good thing is that GitHub is web app, so for UI related tweaks, we can introduce an "improvement" via Safari extensions.
It is nice if we can host such a thing in WebKit tree to ease development on GitHub.
Raised at https://webkit.slack.com/archives/CTV4FGWF4/p1650057108663419?thread_ts=1645753205.677369&cid=CTV4FGWF4
Darin Adler 3 days ago
I learned that truly gigantic patches are a little harder to review in GitHub than bugs.webkit.org
yusukesuzuki 3 days ago
I wonder if we can have some good improvement :slightly_smiling_face: rdar://91790051
Darin Adler 3 days ago
WebKit performance is definitely one reason. Defaulting to not expanding the diff for files with a lot of changes is a related second frustration. Can’t just scroll through. I also find it harder to walk from comment to comment
yusukesuzuki 3 days ago
https://gist.github.com/juanca/5fd799c5b094e3e4f8b709cd101d7403
This bookmarklet would help :slightly_smiling_face:
yusukesuzuki 3 days ago
I wonder if we can have Safari extension for github.com/WebKit/WebKit in the tree with all of these kind of hacks.
Darin Adler 1 day ago
Seems like we need to change those bookmarklets into an extension we’ll all want
yusukesuzuki 1 day ago
Good thing is that GitHub is a web app. So with extension, we can apply UI related changes by ourselves.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/92297393>