Bug 239434

Summary: AX: Update the isolated tree in response to AXElementBusyChanged and AXTextChanged notifications
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Tyler Wilcock
Reported 2022-04-17 08:53:13 PDT
Update the isolated tree in response to AXElementBusyChanged and AXTextChanged notifications
Attachments
Patch (30.19 KB, patch)
2022-04-17 09:00 PDT, Tyler Wilcock 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (29.67 KB, patch)
2022-04-17 09:30 PDT, Tyler Wilcock 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (29.67 KB, patch)
2022-04-17 10:20 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (29.80 KB, patch)
2022-04-17 10:41 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (29.96 KB, patch)
2022-04-18 15:23 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-04-17 08:53:21 PDT
<rdar://problem/91862868>
Tyler Wilcock
Comment 2 2022-04-17 09:00:03 PDT
Created attachment 457771 [details] Patch
chris fleizach
Comment 3 2022-04-17 09:05:18 PDT
Comment on attachment 457771 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457771&action=review > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1302 > +void AccessibilityNodeObject::setElementAttributeValue(const QualifiedName& attributeName, bool value) Do we still use this for anything?
Tyler Wilcock
Comment 4 2022-04-17 09:30:14 PDT
Created attachment 457772 [details] Patch
Tyler Wilcock
Comment 5 2022-04-17 09:30:59 PDT
> > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1302 > > +void AccessibilityNodeObject::setElementAttributeValue(const QualifiedName& attributeName, bool value) > > Do we still use this for anything? Nope, good point! Removed the function entirely in the latest patch.
Tyler Wilcock
Comment 6 2022-04-17 10:20:01 PDT
Created attachment 457773 [details] Patch
Tyler Wilcock
Comment 7 2022-04-17 10:41:59 PDT
Created attachment 457774 [details] Patch
Andres Gonzalez
Comment 8 2022-04-18 13:14:37 PDT
(In reply to Tyler Wilcock from comment #7) > Created attachment 457774 [details] > Patch --- a/Source/WebCore/ChangeLog +++ a/Source/WebCore/ChangeLog + Tests: accessibility/accessibility-text-updates-after-dynamic-change.html Can we call this just accessibility/text-updates-after-dynamic-change.html?
Tyler Wilcock
Comment 9 2022-04-18 15:23:24 PDT
Created attachment 457829 [details] Patch
Tyler Wilcock
Comment 10 2022-04-18 20:20:31 PDT
> + Tests: > accessibility/accessibility-text-updates-after-dynamic-change.html > > Can we call this just accessibility/text-updates-after-dynamic-change.html? Good idea, fixed this.
EWS
Comment 11 2022-04-18 20:26:23 PDT
Committed r293006 (249745@main): <https://commits.webkit.org/249745@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457829 [details].
Note You need to log in before you can comment on or make changes to this bug.