Bug 239400 – Allow C API clients to get the WKProcessTerminationReason in processDidCrash functions, and use in WebKitTestRunner

• Component: WebKit2
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Allow C API clients to get the WKProcessTerminationReason in processDidCrash functions, and use in WebKitTestRunner

[Simon Fraser (smfr)]

Created attachment 457718 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 457723 [details]
Patch

[Sam Weinig]

Comment on attachment 457723 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457723&action=review

> Source/WebKit/UIProcess/API/C/WKContext.h:137
> +    WKContextChildProcessDidCrashWithDetailsCallback                    networkProcessDidCrashWithDetails;

How would a single one of these that gets passed a "process-kind" enum be?

[Sam Weinig]

Comment on attachment 457723 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457723&action=review

>> Source/WebKit/UIProcess/API/C/WKContext.h:137
>> +    WKContextChildProcessDidCrashWithDetailsCallback                    networkProcessDidCrashWithDetails;
> 
> How would a single one of these that gets passed a "process-kind" enum be?

Or better yet, since this seems to be a pattern, a single one that gets passed a new WKObjectRef (I think that is the base name) "crash info" object that has some functions to grab the pid/reason?

[Simon Fraser (smfr)]

Both good suggestions, but is it really worth spending effort polishing the legacy C SPI?

[Simon Fraser (smfr)]

Alternatively we could replace this with Objective-C SPI

[Sam Weinig]

(In reply to Simon Fraser (smfr) from comment #5)
> Both good suggestions, but is it really worth spending effort polishing the
> legacy C SPI?

I was thinking of it not as polish but as just more ergonomical for going forward, since we don't really have a path off of it.

(In reply to Simon Fraser (smfr) from comment #6)
> Alternatively we could replace this with Objective-C SPI

Isn't this used by the non-cocoa ports as well?

[EWS]

Committed r292970 (249733@main): <https://commits.webkit.org/249733@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457723 [details].

[Radar WebKit Bug Importer]

<rdar://problem/91917423>