Bug 23935

Summary:

Nested :not() and non-simple selectors in :not() should be invalid

Product:

WebKit

Reporter:

David Smith <catfish.man>

Component:

CSS

Assignee:

David Smith <catfish.man>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Fail to parse the selector if it has nested :not()s	none
Coding style tweak	none
resolve-Changelogs screwed up before	hyatt: review+
Fix the remaining tests.	catfish.man: review+

David Smith

Reported 2009-02-12 16:07:27 PST

Not doing this causes 8 failures on http://ejohn.org/apps/selectortest/#target

Attachments
Fail to parse the selector if it has nested :not()s (5.72 KB, patch) 2009-02-12 16:09 PST, David Smith	no flags	Details Formatted Diff Diff
Coding style tweak (6.29 KB, patch) 2009-02-12 17:02 PST, David Smith	no flags	Details Formatted Diff Diff
resolve-Changelogs screwed up before (5.85 KB, patch) 2009-02-12 17:04 PST, David Smith	hyatt: review+	Details Formatted Diff Diff
Fix the remaining tests. (6.84 KB, patch) 2009-02-12 17:18 PST, David Smith	catfish.man: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

David Smith

Comment 1 2009-02-12 16:09:59 PST

Created attachment 27627 [details] Fail to parse the selector if it has nested :not()s Just rebuilding to do a final layout test run now; it passed before svn upping so it should still pass.

David Smith

Comment 2 2009-02-12 17:02:53 PST

Created attachment 27631 [details] Coding style tweak

David Smith

Comment 3 2009-02-12 17:04:01 PST

Created attachment 27632 [details] resolve-Changelogs screwed up before

Dave Hyatt

Comment 4 2009-02-12 17:08:39 PST

Comment on attachment 27632 [details] resolve-Changelogs screwed up before r=me

David Smith

Comment 5 2009-02-12 17:18:15 PST

Created attachment 27633 [details] Fix the remaining tests. Reviewed on irc

Note You need to log in before you can comment on or make changes to this bug.