Summary: | Need way to subscribe to labels on GitHub | ||
---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | jbedard, mcatanzaro, pgriffis, rik, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | All | ||
OS: | All | ||
Bug Depends on: | |||
Bug Blocks: | 239082 |
Description
Michael Catanzaro
2022-04-12 06:29:41 PDT
(In reply to Michael Catanzaro from comment #0) > For pull requests to find interested reviewers, we need a way to subscribe > to labels. Well we kind of solved this with the CODEOWNERS file, which is even more flexible, but problem is non-reviewers need to be able to subscribe to stuff too. So we still need a way to subscribe to labels. (In reply to Michael Catanzaro from comment #2) > (In reply to Michael Catanzaro from comment #0) > > For pull requests to find interested reviewers, we need a way to subscribe > > to labels. > > Well we kind of solved this with the CODEOWNERS file, which is even more > flexible, but problem is non-reviewers need to be able to subscribe to stuff > too. So we still need a way to subscribe to labels. I think this is more accurately "non-contributors", there isn't anything stopping a non-reviewer from watching a specific directory, and there are often cases where a non-reviewer's approval is still relevant (even though `merge-queue` won't respect it as a review). I don't disagree with your point, just wanted to call out that (in my opinion, at least) one does not need to be a reviewer to be in code owners. As an example, I have Zhifei Fang as code owner of some services code he is definitely the expert on despite Zhifei not yet being a reviewer. That's too inflexible, I'm afraid. Let me reword the title to be more clear: what I'm looking for is subscribe to labels, so you can follow issues or pull requests with a specific label. I'm still surprised GitHub does not have this feature built-in, but I understand it's possible via bots or automation. Don found: https://github.com/bytecodealliance/subscribe-to-label-action which is probably the best we're going to be able to do. My concern with @ing users is it’s not clear how expandable such a system is, given we often have dozens of users tracking a specific PR. Probably will just have a comment we constantly edit, but that feels hackey… |