Bug 239059

Summary: [IFC][Integration] LayoutIntegration::LineLayout should not expose InlineContent
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, darin, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

zalan
Reported 2022-04-10 21:16:28 PDT
ssia
Attachments
Patch (9.73 KB, patch)
2022-04-10 21:19 PDT, zalan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (9.73 KB, patch)
2022-04-11 15:49 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-04-10 21:19:13 PDT
Created attachment 457230 [details] Patch
Darin Adler
Comment 2 2022-04-11 14:48:58 PDT
Comment on attachment 457230 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457230&action=review > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:497 > + return m_inlineContent ? m_inlineContent->hasVisualOverflow() : false; I like writing these with &&, would you consider that?
zalan
Comment 3 2022-04-11 14:51:57 PDT
(In reply to Darin Adler from comment #2) > Comment on attachment 457230 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457230&action=review > > > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:497 > > + return m_inlineContent ? m_inlineContent->hasVisualOverflow() : false; > > I like writing these with &&, would you consider that? good point! yes!
zalan
Comment 4 2022-04-11 15:49:20 PDT
Created attachment 457295 [details] Patch
EWS
Comment 5 2022-04-11 18:31:21 PDT
Committed r292752 (249536@main): <https://commits.webkit.org/249536@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457295 [details].
Radar WebKit Bug Importer
Comment 6 2022-04-11 18:32:15 PDT
<rdar://problem/91601019>
Note You need to log in before you can comment on or make changes to this bug.