Bug 238928

Summary: [JSC] Reduce Baseline JIT code size in debug builds
Product: WebKit Reporter: Geza Lore <glore>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Geza Lore
Reported 2022-04-07 06:05:38 PDT
[JSC] Reduce Baseline JIT code size in debug builds
Attachments
Patch (7.18 KB, patch)
2022-04-07 06:34 PDT, Geza Lore 		no flags
DetailsFormatted DiffDiff
Patch (8.09 KB, patch)
2022-04-07 10:36 PDT, Geza Lore 		no flags
DetailsFormatted DiffDiff
Patch (8.20 KB, patch)
2022-04-11 02:55 PDT, Geza Lore 		no flags
DetailsFormatted DiffDiff
Patch (8.19 KB, patch)
2022-04-11 04:34 PDT, Geza Lore 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Geza Lore
Comment 1 2022-04-07 06:34:40 PDT
Created attachment 456917 [details] Patch
Geza Lore
Comment 2 2022-04-07 10:36:15 PDT
Created attachment 456940 [details] Patch
Yusuke Suzuki
Comment 3 2022-04-10 01:45:41 PDT
Comment on attachment 456940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456940&action=review > Source/JavaScriptCore/jit/JIT.cpp:682 > +#if CPU(X86_64) > + jit.subPtr(TrustedImm32(sizeof(void*)), expectedStackPointerGPR); // Call instruction pushed to stack > +#endif You can use prologueStackPointerDelta() and sizeof(CallerFrameAndPC) to compute it for all architectures.
Geza Lore
Comment 4 2022-04-11 02:55:41 PDT
Created attachment 457240 [details] Patch
Geza Lore
Comment 5 2022-04-11 02:56:17 PDT
(In reply to Yusuke Suzuki from comment #3) > Comment on attachment 456940 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=456940&action=review > > > Source/JavaScriptCore/jit/JIT.cpp:682 > > +#if CPU(X86_64) > > + jit.subPtr(TrustedImm32(sizeof(void*)), expectedStackPointerGPR); // Call instruction pushed to stack > > +#endif > > You can use prologueStackPointerDelta() and sizeof(CallerFrameAndPC) to > compute it for all architectures. Neat, thanks. r?
Geza Lore
Comment 6 2022-04-11 04:34:41 PDT
Created attachment 457245 [details] Patch
Saam Barati
Comment 7 2022-04-11 09:07:55 PDT
Comment on attachment 457245 [details] Patch r=me
EWS
Comment 8 2022-04-12 00:52:39 PDT
Committed r292767 (249551@main): <https://commits.webkit.org/249551@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457245 [details].
Radar WebKit Bug Importer
Comment 9 2022-04-12 00:53:14 PDT
<rdar://problem/91612747>
Note You need to log in before you can comment on or make changes to this bug.