Bug 238912

Summary: Adjust and refactor some UA styles and logic for injecting Live Text
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, kangil.han, katherine_cheney, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
akeerthi: review+, ews-feeder: commit-queue-
Patch for landing none

Wenson Hsieh
Reported 2022-04-06 16:58:51 PDT
rdar://91383570
Attachments
Patch (13.27 KB, patch)
2022-04-06 18:01 PDT, Wenson Hsieh 		akeerthi: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (13.37 KB, patch)
2022-04-07 07:53 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2022-04-06 18:01:25 PDT
Created attachment 456879 [details] Patch
Aditya Keerthi
Comment 2 2022-04-06 20:30:19 PDT
Comment on attachment 456879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456879&action=review > Source/WebCore/dom/ImageOverlay.cpp:445 > + if (lines.size() > 2) Nit: Named constant?
Wenson Hsieh
Comment 3 2022-04-07 07:52:36 PDT
Comment on attachment 456879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456879&action=review Thanks for the review! >> Source/WebCore/dom/ImageOverlay.cpp:445 >> + if (lines.size() > 2) > > Nit: Named constant? Makes sense — I'll change this to use `constexpr auto maxLineCountForCenterAlignedText = 2;`
Wenson Hsieh
Comment 4 2022-04-07 07:53:55 PDT
Created attachment 456924 [details] Patch for landing
EWS
Comment 5 2022-04-07 10:23:21 PDT
Committed r292543 (249381@main): <https://commits.webkit.org/249381@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456924 [details].
Note You need to log in before you can comment on or make changes to this bug.