Bug 238894

Summary: [:has() pseudo-class] Support invalidation for :placeholder-shown
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: CSSAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, mifenton, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 234556    
Attachments:
Description Flags
Patch
none
Patch
simon.fraser: review+, ews-feeder: commit-queue-
[fast-cq] Patch none

Tim Nguyen (:ntim)
Reported 2022-04-06 14:42:23 PDT
See title
Attachments
Patch (3.98 KB, patch)
2022-04-06 14:54 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (3.96 KB, patch)
2022-04-06 15:08 PDT, Tim Nguyen (:ntim) 		simon.fraser: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
[fast-cq] Patch (4.05 KB, patch)
2022-04-06 21:22 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1 2022-04-06 14:54:36 PDT
Created attachment 456866 [details] Patch
Radar WebKit Bug Importer
Comment 2 2022-04-06 14:56:09 PDT
<rdar://problem/91377662>
Tim Nguyen (:ntim)
Comment 3 2022-04-06 15:08:53 PDT
Created attachment 456871 [details] Patch
EWS
Comment 4 2022-04-06 17:10:06 PDT
Found 1 new test failure: imported/blink/fast/forms/textarea-placeholder-visibility-3.html
Tim Nguyen (:ntim)
Comment 5 2022-04-06 21:22:28 PDT
Created attachment 456888 [details] [fast-cq] Patch
Tim Nguyen (:ntim)
Comment 6 2022-04-06 21:26:47 PDT
For the imported/blink/fast/forms/textarea-placeholder-visibility-3.html failure, it seems like we need to call TextControlPlaceholderElement::resolveCustomStyle(). Not sure if this is an isolated case where Style::PseudoClassChangeInvalidation is not enough compared to invalidateStyleForSubtree(), but might be worth checking. In the meantime, I've added this for the placeholder case: if (RefPtr placeholder = placeholderElement()) placeholder->invalidateStyle();
EWS
Comment 7 2022-04-06 21:30:18 PDT
Committed r292523 (249361@main): <https://commits.webkit.org/249361@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456888 [details].
Note You need to log in before you can comment on or make changes to this bug.