Bug 238887 – Have ImageBuffer store the RenderingPurpose, and send it to the GPU process

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Have ImageBuffer store the RenderingPurpose, and send it to the GPU process

[Simon Fraser (smfr)]

Created attachment 456857 [details]
Patch

[Said Abou-Hallawa]

Comment on attachment 456857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456857&action=review

> Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:452
> +    RenderingPurpose purpose = m_imageBuffer ? m_imageBuffer->renderingPurpose() : RenderingPurpose::DOM;

I could not understand what this statement means.When can m_imageBuffer be null? And why do we use m_imageBuffer->renderingPurpose() or RenderingPurpose::DOM as the renderingPurpose of the new compatible ImageBuffer? Suppose RemoteDisplayListRecorderProxy was created for RenderingPurpose::Canvas and we are creating a compatible ImageBuffer for SVG clipper, why is this ImageBuffer created with RenderingPurpose::Canvas?

[Simon Fraser (smfr)]

I tried plumbing RenderingPurpose through more but it got out of hand. Landing the patch with a FIXME.

https://trac.webkit.org/changeset/292557/webkit

[Radar WebKit Bug Importer]

<rdar://problem/91440114>