Bug 238793

Summary: update-angle output varies unpredictably due to blob hash abbreviation
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: ANGLEAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, kbr, kkinnunen, koivisto, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 15   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 238794    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Kimmo Kinnunen
Reported 2022-04-05 01:03:42 PDT
update-angle output varies unpredictably due to blob hash abbreviation the script should use diff --full-index
Attachments
Patch (18.06 KB, patch)
2022-04-05 01:23 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2022-04-05 01:23:50 PDT
Created attachment 456683 [details] Patch
EWS Watchlist
Comment 2 2022-04-05 01:25:23 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Antti Koivisto
Comment 3 2022-04-05 01:41:58 PDT
Comment on attachment 456683 [details] Patch rs=me
EWS
Comment 4 2022-04-05 02:41:21 PDT
Committed r292388 (249253@main): <https://commits.webkit.org/249253@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456683 [details].
Radar WebKit Bug Importer
Comment 5 2022-04-05 02:42:14 PDT
<rdar://problem/91284547>
Note You need to log in before you can comment on or make changes to this bug.