Bug 238779 – [WKTR] [DRT] Only enable WebGPU for the LayoutTests/http/tests/webgpu directory

• Component: WebGPU
• Status: RESOLVED FIXED

[Myles C. Maxfield]

[WKTR] [DRT] Add the concept a non-experimental-feature which should obey the --no-enable-all-experimental-features flag

[Myles C. Maxfield]

Created attachment 456655 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 456655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456655&action=review

> Tools/ChangeLog:10
> +        This adds a set of non-experimental features which should be treated as experimental features
> +        for the purpose of the --no-enable-all-experimental-features flag. Right now, the set has one
> +        entry: WebGPU. (So, when --no-enable-all-experimental-features is specified, WebGPU is disabled.)

Can we instead do this via some kind of annotation in the .yaml files?

Or can we just have WTR enable WebGPU based on directory name, for now?

This additional category of "experimental feature but not an experimental feature" is rather confusing.

[Radar WebKit Bug Importer]

<rdar://problem/91599623>

[Radar WebKit Bug Importer]

<rdar://problem/91608718>

[Myles C. Maxfield]

Created attachment 457311 [details]
Patch

[Darin Adler]

Comment on attachment 457311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457311&action=review

> Tools/TestRunnerShared/TestFeatures.cpp:127
> +    return pathContains(pathOrURL, "127.0.0.1:8000/webgpu");

I wish I understood why others above are looking for "localhost" and this is looking for "127.0.0.1".

This directory-specific stuff should be a technique of last resort.

I suppose this is temporary, though, so I will stand down for now.

[Myles C. Maxfield]

Comment on attachment 457311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457311&action=review

>> Tools/TestRunnerShared/TestFeatures.cpp:127
>> +    return pathContains(pathOrURL, "127.0.0.1:8000/webgpu");
> 
> I wish I understood why others above are looking for "localhost" and this is looking for "127.0.0.1".
> 
> This directory-specific stuff should be a technique of last resort.
> 
> I suppose this is temporary, though, so I will stand down for now.

The directories above use :8800, which is the port used for Web Platform Tests. Non-WPT-http-tests seem to use 127.0.0.1.

I agree with you about the last-resort-ness; please see https://bugs.webkit.org/show_bug.cgi?id=238779#c2.

[EWS]

Committed r292788 (249571@main): <https://commits.webkit.org/249571@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457311 [details].