Bug 238753

Summary: [PlayStation] Enable libpas.
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: bmallocAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, basuke, don.olmstead, ews-watchlist, ggaren, gyuyoung.kim, ryuan.choi, sergio, stephan.szabo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
PATCH
none
PATCH
none
PATCH none

Basuke Suzuki
Reported 2022-04-04 12:14:40 PDT
It's ready.
Attachments
PATCH (1.35 KB, patch)
2022-04-04 12:20 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
PATCH (5.20 KB, patch)
2022-04-04 12:22 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
PATCH (9.45 KB, patch)
2022-04-04 14:27 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2022-04-04 12:20:10 PDT
Created attachment 456604 [details] PATCH
Basuke Suzuki
Comment 2 2022-04-04 12:22:44 PDT
Created attachment 456605 [details] PATCH
Yusuke Suzuki
Comment 3 2022-04-04 12:51:03 PDT
Comment on attachment 456605 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=456605&action=review Nice, some early comments. > Source/bmalloc/libpas/src/libpas/pas_platform.h:178 > +#if !defined(alignof) > +#define alignof _Alignof > +#endif Let's define `PAS_ALIGNOF` > Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c:53 > +#if PAS_PLATFORM(PLAYSTATION) > +#include <pthread_np.h> > +#define pthread_getname_np(a, b, c) pthread_get_name_np(a, b) > +#endif Probably you can just add this switch in dump_thread_diagnostics function directly since it is the only one function using pthread_get_name_np.
Basuke Suzuki
Comment 4 2022-04-04 13:33:36 PDT
Comment on attachment 456605 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=456605&action=review Thanks for the quick comment. >> Source/bmalloc/libpas/src/libpas/pas_platform.h:178 >> +#endif > > Let's define `PAS_ALIGNOF` Good idea. Thanks. Our some of our old platform doesn't support C11 correctly. >> Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c:53 >> +#endif > > Probably you can just add this switch in dump_thread_diagnostics function directly since it is the only one function using pthread_get_name_np. Sounds good.
Basuke Suzuki
Comment 5 2022-04-04 14:27:08 PDT
Created attachment 456633 [details] PATCH
Yusuke Suzuki
Comment 6 2022-04-04 15:38:20 PDT
Comment on attachment 456633 [details] PATCH r=me
Basuke Suzuki
Comment 7 2022-04-05 10:59:57 PDT
Comment on attachment 456633 [details] PATCH All green. Thanks! Yusuke!
EWS
Comment 8 2022-04-05 11:46:21 PDT
Committed r292407 (249270@main): <https://commits.webkit.org/249270@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456633 [details].
Radar WebKit Bug Importer
Comment 9 2022-04-05 11:47:15 PDT
<rdar://problem/91307116>
Note You need to log in before you can comment on or make changes to this bug.