Bug 238742

Summary: Only check isPagedOut() under memory pressure
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, heycam, keith_miller, mark.lam, msaboff, nham, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Geoffrey Garen
Reported 2022-04-04 09:59:09 PDT
Only check isPagedOut() under memory pressure
Attachments
Patch (1.90 KB, patch)
2022-04-04 10:05 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2022-04-04 10:05:53 PDT
Created attachment 456581 [details] Patch
Ben Nham
Comment 2 2022-04-04 10:11:29 PDT
One issue here is that isUnderMemoryPressure() doesn't actually tell you if the system is under memory pressure. Instead it just tells you if your process has received a critical memory pressure notification. They're not the same thing. Maybe we need a new method isSystemUnderMemoryPressure() that checks the system-wide kern.memorystatus_vm_pressure_level sysctl on a timer or something. I guess we can implement that in another patch.
Geoffrey Garen
Comment 3 2022-04-04 11:03:00 PDT
I could change to kern.memorystatus_vm_pressure_level here. Worth it?
Ben Nham
Comment 4 2022-04-04 11:04:29 PDT
(In reply to Geoffrey Garen from comment #3) > I could change to kern.memorystatus_vm_pressure_level here. Worth it? I can probably write another patch that tries to do something sensible. My guess is the patch would also require a small sandbox change. Let's go with the speedo win here for now and we can test that change separately.
EWS
Comment 5 2022-04-04 13:55:12 PDT
Committed r292315 (249208@main): <https://commits.webkit.org/249208@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456581 [details].
Radar WebKit Bug Importer
Comment 6 2022-04-04 13:56:16 PDT
<rdar://problem/91259682>
Note You need to log in before you can comment on or make changes to this bug.