Bug 238729

Summary: [CMake] Provide better messages when gi-docgen cannot be found
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cgarcia, ews-watchlist, gyuyoung.kim, mcatanzaro, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226662
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2022-04-04 02:18:21 PDT
In bug #226662 we switched to gi-docgen, but the errors when gi-docgen is not installed or does not run correctly can be quite cryptic. We would like to also hint to people that gi-docgen can be easily installed at the gi-docgen/ subdirectory of the source tree.
Attachments
Patch (3.01 KB, patch)
2022-04-04 02:21 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2022-04-04 02:21:46 PDT
Created attachment 456550 [details] Patch
EWS
Comment 2 2022-04-04 04:19:01 PDT
Committed r292286 (249184@main): <https://commits.webkit.org/249184@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456550 [details].
Radar WebKit Bug Importer
Comment 3 2022-04-04 04:20:19 PDT
<rdar://problem/91233482>
Note You need to log in before you can comment on or make changes to this bug.