Bug 238587

Summary:	Do not apply intrinsic margin to form controls
Product:	WebKit	Reporter:	zalan <zalan>
Component:	Layout and Rendering	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	ahmad.saleem792, bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=50413 https://bugs.webkit.org/show_bug.cgi?id=107380

Description zalan 2022-03-30 20:52:52 PDT

This was introduce at r10888 with the idea of "With this landing both <input type=button> and <button> will now look like OS X-style widgets." and maybe we should check if this is still the desired approach for our form controls.

Comment 1 Radar WebKit Bug Importer 2022-04-06 20:53:17 PDT

<rdar://problem/91392072>

Comment 2 Sam Sneddon [:gsnedders] 2022-06-06 04:15:26 PDT

Maybe should dupe this and reopen bug 50413?

Comment 3 Ahmad Saleem 2022-10-10 13:05:21 PDT

(In reply to Radar WebKit Bug Importer from comment #1)
> <rdar://problem/91392072>

https://github.com/WebKit/WebKit/commit/100909dabdebd9e08c2472caca086b5162e58315

I discussed with Aditya on Slack and we are thinking of removing old addIntrisic from SDK:

https://github.com/WebKit/WebKit/blob/main/Source/WebCore/style/StyleAdjuster.cpp#L512

and see how it goes. Let me know if there are any other inputs before I do PR some time this week.