Bug 238573

Summary: Add a placeholder for some additional Captive Portal mode settings
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, ggaren, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Brent Fulgham
Reported 2022-03-30 13:50:29 PDT
Add a macro placeholder for some future Captive Portal settings.
Attachments
Patch (1.67 KB, patch)
2022-03-30 13:54 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (1.68 KB, patch)
2022-03-30 14:46 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (1.69 KB, patch)
2022-03-30 15:51 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.69 KB, patch)
2022-03-31 10:20 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-03-30 13:51:14 PDT
<rdar://problem/91064718>
Brent Fulgham
Comment 2 2022-03-30 13:54:25 PDT
Created attachment 456171 [details] Patch
Wenson Hsieh
Comment 3 2022-03-30 14:17:43 PDT
Comment on attachment 456171 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456171&action=review > Source/WebKit/WebProcess/WebPage/WebPage.cpp:4106 > + CAPTIVE_PORTAL_WEB_PAGE_ADDITIONS(); Could we factor this out into a static helper function instead?
Brent Fulgham
Comment 4 2022-03-30 14:46:40 PDT
Created attachment 456178 [details] Patch
Tim Horton
Comment 5 2022-03-30 15:02:40 PDT
Comment on attachment 456178 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456178&action=review > Source/WebKit/WebProcess/WebPage/WebPage.cpp:396 > +#import <WebKitAdditions/WebPageAdditions.h> This should be a .cpp file.
Brent Fulgham
Comment 6 2022-03-30 15:37:26 PDT
Comment on attachment 456178 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456178&action=review >> Source/WebKit/WebProcess/WebPage/WebPage.cpp:396 >> +#import <WebKitAdditions/WebPageAdditions.h> > > This should be a .cpp file. Will fix.
Brent Fulgham
Comment 7 2022-03-30 15:51:48 PDT
Created attachment 456182 [details] Patch
Wenson Hsieh
Comment 8 2022-03-31 08:32:11 PDT
Comment on attachment 456182 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456182&action=review > Source/WebKit/ChangeLog:12 > + (WebKit::adjustSettingsForCaptivePortal): Call new placeholder macro. s/macro/helper function/
Brent Fulgham
Comment 9 2022-03-31 10:20:56 PDT
Created attachment 456252 [details] Patch for landing
EWS
Comment 10 2022-03-31 13:01:53 PDT
Committed r292165 (249072@main): <https://commits.webkit.org/249072@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456252 [details].
Note You need to log in before you can comment on or make changes to this bug.