Bug 238572

Summary: [CSS contain] Containment disables the special handling of the HTML body element for overflow viewport propagation [part2]
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, rbuis, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch ews-feeder: commit-queue-

alan
Reported 2022-03-30 13:22:06 PDT
This is when <html> has the containment.
Attachments
Patch (4.32 KB, patch)
2022-03-30 13:45 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (4.31 KB, patch)
2022-03-30 14:00 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (4.26 KB, patch)
2022-03-30 19:12 PDT, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2022-03-30 13:45:14 PDT
Created attachment 456170 [details] Patch
Simon Fraser (smfr)
Comment 2 2022-03-30 13:47:05 PDT
Comment on attachment 456170 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456170&action=review > Source/WebCore/rendering/RenderBox.cpp:514 > + // (4) No containment is set neither on the body nor on the html document element. neither/nor -> either/or
alan
Comment 3 2022-03-30 14:00:36 PDT
Created attachment 456172 [details] Patch
alan
Comment 4 2022-03-30 19:12:08 PDT
Created attachment 456194 [details] Patch
Rob Buis
Comment 5 2022-03-31 06:29:07 PDT
Nice! When I was working on these tests I could not figure out how to fix these three...
alan
Comment 6 2022-03-31 06:37:23 PDT
(In reply to Rob Buis from comment #5) > Nice! When I was working on these tests I could not figure out how to fix > these three... I am going through this list https://wpt.fyi/results/css/css-contain?label=experimental&label=master&product=chrome&product=firefox&product=safari&aligned&q=label%3Ainterop-2022-contain to see if we can turn some of the red to green.
alan
Comment 7 2022-03-31 06:40:45 PDT
(In reply to zalan from comment #6) > (In reply to Rob Buis from comment #5) > > Nice! When I was working on these tests I could not figure out how to fix > > these three... > I am going through this list > https://wpt.fyi/results/css/css- > contain?label=experimental&label=master&product=chrome&product=firefox&produc > t=safari&aligned&q=label%3Ainterop-2022-contain to see if we can turn some > of the red to green. Sadly I've already seen some non-actionable/needs more thinking failures e.g. https://trac.webkit.org/changeset/292140/webkit
EWS
Comment 8 2022-03-31 06:57:39 PDT
Committed r292157 (249064@main): <https://commits.webkit.org/249064@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456194 [details].
Radar WebKit Bug Importer
Comment 9 2022-03-31 06:58:19 PDT
<rdar://problem/91101177>
Note You need to log in before you can comment on or make changes to this bug.