Bug 238565

Summary: Remove EXPERIMENTAL_FEATURES flag on Cocoa platforms
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, don.olmstead, ews-watchlist, hi, joepeck, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Alex Christensen
Reported 2022-03-30 12:06:17 PDT
Remove EXPERIMENTAL_FEATURES flag
Attachments
Patch (15.12 KB, patch)
2022-03-30 12:10 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (15.16 KB, patch)
2022-03-30 16:31 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2022-03-30 12:10:55 PDT
Created attachment 456161 [details] Patch
Don Olmstead
Comment 2 2022-03-30 15:05:15 PDT
For our CMake ports I'm open to just putting it as ON instead of basing it on the flags. So as an example we have ENABLE_SERVICE_WORKERS as an experimental feature then in this brave new world we'd just make sure that its not enabled by default in the preferences. Is there anything else we should be aware of here when migrating off of ENABLE_EXPERIMENTAL_FEATURES?
Alex Christensen
Comment 3 2022-03-30 16:24:03 PDT
I guess Source/cmake/WebKitFeatures.cmake and Source/cmake/Options*.cmake use this for something else. I'm going to leave that as it is and just remove EXPERIMENTAL_FEATURES from the source.
Alex Christensen
Comment 4 2022-03-30 16:31:33 PDT
Created attachment 456184 [details] Patch
EWS
Comment 5 2022-03-31 05:46:58 PDT
Committed r292156 (249063@main): <https://commits.webkit.org/249063@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456184 [details].
Radar WebKit Bug Importer
Comment 6 2022-03-31 05:47:19 PDT
<rdar://problem/91099190>
Note You need to log in before you can comment on or make changes to this bug.