Bug 238559

Summary: Use dispatch_source_create(DISPATCH_SOURCE_TYPE_SIGNAL, SIGTERM) in setOSTransaction()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2022-03-30 10:37:23 PDT 
Use dispatch_source_create(DISPATCH_SOURCE_TYPE_SIGNAL, SIGTERM) in setOSTransaction() instead of a low-level signal(SIGTERM) handler, as recommended by the XPC team.
This is better becomes it has less limitations about what you can do in the handler. It is also possible to set several handlers this way, in different parts of the code (i.e. also not worry about some other code overriding our handler).
Comment 1 Chris Dumez 2022-03-30 10:38:42 PDT 
Created attachment 456145 [details]
Patch
Comment 2 EWS 2022-03-30 16:34:24 PDT 
Committed r292128 (249038@main): <https://commits.webkit.org/249038@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456145 [details].
Comment 3 Radar WebKit Bug Importer 2022-03-30 16:35:17 PDT 
<rdar://problem/91073577>