Bug 238530

Summary: Prepare Tools/ for making the String(const char*) constructor explicit
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, ggaren, pascoe, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=238525
Bug Depends on:    
Bug Blocks: 238693    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Chris Dumez
Reported 2022-03-29 16:19:06 PDT
Prepare Tools/ for making the String(const char*) constructor explicit.
Attachments
Patch (902.11 KB, patch)
2022-03-29 16:20 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (896.41 KB, patch)
2022-03-30 07:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (896.71 KB, patch)
2022-03-30 08:36 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (893.92 KB, patch)
2022-03-31 20:04 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (894.78 KB, patch)
2022-03-31 21:34 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-03-29 16:20:57 PDT
Created attachment 456078 [details] Patch
Chris Dumez
Comment 2 2022-03-30 07:31:35 PDT
Comment on attachment 456078 [details] Patch Will investigate failures.
Chris Dumez
Comment 3 2022-03-30 07:41:21 PDT
Created attachment 456121 [details] Patch
Chris Dumez
Comment 4 2022-03-30 08:36:54 PDT
Created attachment 456124 [details] Patch
Chris Dumez
Comment 5 2022-03-31 20:04:17 PDT
Created attachment 456312 [details] Patch
Chris Dumez
Comment 6 2022-03-31 21:34:11 PDT
Created attachment 456320 [details] Patch
Chris Dumez
Comment 7 2022-04-01 11:02:39 PDT
Patch is ready for review. In my next patch, I should be able to make the constructor explicit (finally!).
Geoffrey Garen
Comment 8 2022-04-01 11:05:26 PDT
Comment on attachment 456320 [details] Patch r=me
Chris Dumez
Comment 9 2022-04-01 19:01:19 PDT
Comment on attachment 456320 [details] Patch Clearing flags on attachment: 456320 Committed r292251 (249149@trunk): <https://commits.webkit.org/249149@trunk>
Chris Dumez
Comment 10 2022-04-01 19:01:22 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2022-04-01 19:02:22 PDT
<rdar://problem/91191809>
Note You need to log in before you can comment on or make changes to this bug.