Bug 238521

Summary: Add HashTranslator for ASCIILiteral for faster lookup in HashMaps / HashSets
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, benjamin, cfleizach, cmarcelo, darin, dmazzoni, esprehn+autocc, ews-watchlist, ggaren, japhet, jcraig, jdiggs, kangil.han, samuel_white, toyoshim, webkit-bug-importer, yutak
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=238408
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Chris Dumez
Reported 2022-03-29 14:15:08 PDT
Add HashTranslator for ASCIILiteral for faster lookup in HashMaps / HashSets using an ASCIILiteral.
Attachments
Patch (27.50 KB, patch)
2022-03-29 14:17 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (27.39 KB, patch)
2022-03-29 15:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.76 KB, patch)
2022-03-30 09:53 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-03-29 14:17:10 PDT
Created attachment 456057 [details] Patch
Chris Dumez
Comment 2 2022-03-29 15:10:15 PDT
Created attachment 456067 [details] Patch
Geoffrey Garen
Comment 3 2022-03-29 20:30:13 PDT
Comment on attachment 456067 [details] Patch r=me
EWS
Comment 4 2022-03-30 07:57:52 PDT
Committed r292106 (249026@main): <https://commits.webkit.org/249026@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456067 [details].
Radar WebKit Bug Importer
Comment 5 2022-03-30 07:58:17 PDT
<rdar://problem/91044544>
Andres Gonzalez
Comment 6 2022-03-30 09:53:50 PDT
Reopening to attach new patch.
Andres Gonzalez
Comment 7 2022-03-30 09:53:53 PDT
Created attachment 456134 [details] Patch
Chris Dumez
Comment 8 2022-03-30 09:58:00 PDT
Reopened by mistake.
Andres Gonzalez
Comment 9 2022-03-30 10:01:03 PDT
(In reply to Chris Dumez from comment #8) > Reopened by mistake. Yes, sorry about that, problem merging the ChangeLog.
Darin Adler
Comment 10 2022-03-30 10:47:54 PDT
Comment on attachment 456067 [details] Patch Seems like we should also eventually add a mechanism so there is a default translator for each type, so we can get rid of most of the explicit <HashTranslatorASCIILiteral>.
Note You need to log in before you can comment on or make changes to this bug.