Bug 238498

Summary: Implement persistent notification handling
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, beidson, cdumez, ews-watchlist, gyuyoung.kim, nham, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

youenn fablet
Reported 2022-03-29 02:31:16 PDT
Implement persistent notification handling
Attachments
Patch (74.13 KB, patch)
2022-03-29 02:52 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (74.33 KB, patch)
2022-03-29 04:19 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (78.26 KB, patch)
2022-03-30 02:33 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (77.37 KB, patch)
2022-03-30 05:21 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 2 2022-03-29 02:33:46 PDT
<rdar://problem/90972545>
youenn fablet
Comment 3 2022-03-29 02:52:25 PDT
Created attachment 456009 [details] Patch
youenn fablet
Comment 4 2022-03-29 04:19:42 PDT
Created attachment 456014 [details] Patch
youenn fablet
Comment 5 2022-03-29 13:07:01 PDT
Comment on attachment 456014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456014&action=review > Source/WebCore/Modules/notifications/Notification.cpp:69 > + notification->showSoon(); Looking at it again, calling showSoon should be removed. Probably worth moving showSoon call out of the Notification::create object.
Brady Eidson
Comment 6 2022-03-29 13:19:12 PDT
Comment on attachment 456014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456014&action=review >> Source/WebCore/Modules/notifications/Notification.cpp:69 >> + notification->showSoon(); > > Looking at it again, calling showSoon should be removed. Probably worth moving showSoon call out of the Notification::create object. Definitely should be: In this case we're not showing it. Agree with the refactor. > Source/WebKit/NetworkProcess/NetworkProcess.cpp:2332 > > + stray newline
youenn fablet
Comment 7 2022-03-30 02:33:19 PDT
Created attachment 456104 [details] Patch for landing
youenn fablet
Comment 8 2022-03-30 03:06:46 PDT
> > Looking at it again, calling showSoon should be removed. Probably worth moving showSoon call out of the Notification::create object. > > Definitely should be: In this case we're not showing it. > > Agree with the refactor. I needed to do a few more refactoring since now we are not reusing the already created Notification object but a new one that should have a matching identifier.
youenn fablet
Comment 9 2022-03-30 05:21:45 PDT
Created attachment 456114 [details] Patch for landing
EWS
Comment 10 2022-03-30 11:41:33 PDT
Committed r292110 (249029@main): <https://commits.webkit.org/249029@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456114 [details].
Note You need to log in before you can comment on or make changes to this bug.