Bug 238487

Summary: Remove -[WKWebsiteDataStore _indexedDBDatabaseDirectory]
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Sihui Liu
Reported 2022-03-28 22:35:02 PDT
This is not used in SPI clients; and we have _indexedDBDatabaseDirectory in _WKWebsiteDataStoreConfiguration.
Attachments
Patch (5.50 KB, patch)
2022-03-28 22:38 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.41 KB, patch)
2022-03-30 11:23 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2022-03-28 22:38:30 PDT
Created attachment 455993 [details] Patch
Alex Christensen
Comment 2 2022-03-30 10:57:18 PDT
Comment on attachment 455993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455993&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:-60 > -@property (nonatomic, readonly) NSURL *_indexedDBDatabaseDirectory WK_API_DEPRECATED_WITH_REPLACEMENT("_WKWebsiteDataStoreConfiguration._indexedDBDatabaseDirectory", macos(10.11, 11.0), ios(9.0, 14.0)); Can we also remove from WKWebsiteDataStore.mm?
Sihui Liu
Comment 3 2022-03-30 11:20:27 PDT
Comment on attachment 455993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455993&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:-60 >> -@property (nonatomic, readonly) NSURL *_indexedDBDatabaseDirectory WK_API_DEPRECATED_WITH_REPLACEMENT("_WKWebsiteDataStoreConfiguration._indexedDBDatabaseDirectory", macos(10.11, 11.0), ios(9.0, 14.0)); > > Can we also remove from WKWebsiteDataStore.mm? Sure.
Sihui Liu
Comment 4 2022-03-30 11:23:58 PDT
Created attachment 456155 [details] Patch for landing
EWS
Comment 5 2022-03-30 16:20:32 PDT
Committed r292126 (249036@main): <https://commits.webkit.org/249036@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456155 [details].
Radar WebKit Bug Importer
Comment 6 2022-03-30 16:21:15 PDT
<rdar://problem/91072951>
Note You need to log in before you can comment on or make changes to this bug.