Bug 238425

Summary: Use system colors for <dialog> default styling
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: CSSAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: dvpdiner2, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 14   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugzilla.mozilla.org/show_bug.cgi?id=1761611
https://github.com/whatwg/html/issues/7754
Bug Depends on: 238502    
Bug Blocks: 84635    
Attachments:
Description Flags
[fast-cq] Patch none

Tim Nguyen (:ntim)
Reported 2022-03-27 14:39:51 PDT
Notably to get dark theme friendly styling like Chromium (which uses -internal-light-dark(white, black) for the background). Firefox is planning to use Canvas/CanvasText in https://bugzilla.mozilla.org/show_bug.cgi?id=1761611 This is also the official proposal: https://github.com/whatwg/html/issues/7754
Attachments
[fast-cq] Patch (3.21 KB, patch)
2022-03-29 04:55 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1 2022-03-29 04:55:55 PDT
Created attachment 456017 [details] [fast-cq] Patch
EWS
Comment 2 2022-03-29 05:19:57 PDT
Tools/Scripts/svn-apply failed to apply attachment 456017 [details] to trunk. Please resolve the conflicts and upload a new patch.
EWS
Comment 3 2022-03-29 05:25:43 PDT
Committed r292029 (248972@main): <https://commits.webkit.org/248972@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456017 [details].
Radar WebKit Bug Importer
Comment 4 2022-03-29 05:26:17 PDT
<rdar://problem/90977336>
Tim Nguyen (:ntim)
Comment 5 2022-03-31 02:55:04 PDT
Test gardening for iOS done here: https://bugs.webkit.org/show_bug.cgi?id=238599
Note You need to log in before you can comment on or make changes to this bug.