Bug 238422

Summary: Drop unnecessary isReachableFromDOM() function in JSNodeCustom.cpp
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, darin, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch peng.liu6: review+, ews-feeder: commit-queue-

Chris Dumez
Reported 2022-03-26 16:26:18 PDT
Drop unnecessary isReachableFromDOM() function in JSNodeCustom.cpp and inline its implementation in the only caller instead.
Attachments
Patch (2.82 KB, patch)
2022-03-26 16:27 PDT, Chris Dumez 		peng.liu6: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-03-26 16:27:20 PDT
Created attachment 455859 [details] Patch
Peng Liu
Comment 2 2022-03-26 21:01:35 PDT
Comment on attachment 455859 [details] Patch Nice cleanup.
Chris Dumez
Comment 3 2022-03-26 22:04:19 PDT
Comment on attachment 455859 [details] Patch Thanks for reviewing!
EWS
Comment 4 2022-03-26 22:04:43 PDT
peng.liu6@icloud.com does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json. Rejecting attachment 455859 [details] from commit queue.
Chris Dumez
Comment 5 2022-03-26 22:05:37 PDT
(In reply to EWS from comment #4) > peng.liu6@icloud.com does not have reviewer permissions according to > https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors. > json. > > Rejecting attachment 455859 [details] from commit queue. Looks like you will need to update your email in contributors.json Peng.
Chris Dumez
Comment 6 2022-03-28 07:14:17 PDT
Committed r291963 (248928@trunk): <https://commits.webkit.org/248928@trunk>
Radar WebKit Bug Importer
Comment 7 2022-03-28 07:15:21 PDT
<rdar://problem/90920497>
Note You need to log in before you can comment on or make changes to this bug.