Bug 238420

Summary: Use StringView for Yarr / RegularExpression parsing
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: JavaScriptCoreAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, keith_miller, mark.lam, msaboff, philipj, saam, sam, sergio, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2022-03-26 16:01:49 PDT
Use StringView for Yarr / RegularExpression parsing, to avoid unnecessary String construction in some cases. It is not uncommon for the pattern to be a string literal.
Attachments
Patch (21.39 KB, patch)
2022-03-26 16:03 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-03-26 16:03:51 PDT
Created attachment 455857 [details] Patch
EWS
Comment 2 2022-03-28 10:26:27 PDT
Committed r291972 (248936@main): <https://commits.webkit.org/248936@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455857 [details].
Radar WebKit Bug Importer
Comment 3 2022-03-28 10:27:17 PDT
<rdar://problem/90931200>
Darin Adler
Comment 4 2022-03-28 15:08:42 PDT
Comment on attachment 455857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455857&action=review > Source/JavaScriptCore/yarr/YarrJIT.cpp:4655 > + StringView m_patternString; This could be const StringView.
Chris Dumez
Comment 5 2022-03-28 15:24:48 PDT
(In reply to Darin Adler from comment #4) > Comment on attachment 455857 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=455857&action=review > > > Source/JavaScriptCore/yarr/YarrJIT.cpp:4655 > > + StringView m_patternString; > > This could be const StringView. Fixed in <https://commits.webkit.org/r291997>.
Note You need to log in before you can comment on or make changes to this bug.