Bug 238404

Summary: Speed up Element::removedFromAncestor()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, darin, esprehn+autocc, ews-watchlist, ggaren, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2022-03-25 19:48:38 PDT 
Speed up Element::removedFromAncestor() by inlining some of the functions it is calling.
Comment 1 Chris Dumez 2022-03-25 19:49:43 PDT 
Created attachment 455816 [details]
Patch
Comment 2 Chris Dumez 2022-03-26 14:21:52 PDT 
Comment on attachment 455816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455816&action=review

> Source/WebCore/ChangeLog:9
> +        This is a confirmed 1.5-2% progression on Speedometer on iMac 20,1.

Sadly, it seems perf-neutral on MacBook Air 10,1 (Apple Silicon). A bit surprising given how much it seems to help on Intel but anyway...
Comment 3 Geoffrey Garen 2022-03-28 10:07:03 PDT 
Comment on attachment 455816 [details]
Patch

r=me
Comment 4 EWS 2022-03-28 11:47:06 PDT 
Committed r291981 (248940@main): <https://commits.webkit.org/248940@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455816 [details].
Comment 5 Radar WebKit Bug Importer 2022-03-28 11:48:27 PDT 
<rdar://problem/90936680>