Bug 238404

Summary: Speed up Element::removedFromAncestor()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, darin, esprehn+autocc, ews-watchlist, ggaren, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2022-03-25 19:48:38 PDT
Speed up Element::removedFromAncestor() by inlining some of the functions it is calling.
Attachments
Patch (9.26 KB, patch)
2022-03-25 19:49 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-03-25 19:49:43 PDT
Created attachment 455816 [details] Patch
Chris Dumez
Comment 2 2022-03-26 14:21:52 PDT
Comment on attachment 455816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455816&action=review > Source/WebCore/ChangeLog:9 > + This is a confirmed 1.5-2% progression on Speedometer on iMac 20,1. Sadly, it seems perf-neutral on MacBook Air 10,1 (Apple Silicon). A bit surprising given how much it seems to help on Intel but anyway...
Geoffrey Garen
Comment 3 2022-03-28 10:07:03 PDT
Comment on attachment 455816 [details] Patch r=me
EWS
Comment 4 2022-03-28 11:47:06 PDT
Committed r291981 (248940@main): <https://commits.webkit.org/248940@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455816 [details].
Radar WebKit Bug Importer
Comment 5 2022-03-28 11:48:27 PDT
<rdar://problem/90936680>
Note You need to log in before you can comment on or make changes to this bug.