Bug 238401

Summary: Clamp degenerate calc() values for <angle>
Product: WebKit Reporter: Nikos Mouchtaris <nmouchtaris>
Component: New BugsAssignee: Nikos Mouchtaris <nmouchtaris>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
simon.fraser: review+
Patch none

Nikos Mouchtaris
Reported 2022-03-25 17:54:05 PDT
Clamp degenerate calc() values for <angle>
Attachments
Patch (5.85 KB, patch)
2022-03-25 22:49 PDT, Nikos Mouchtaris 		simon.fraser: review+
DetailsFormatted DiffDiff
Patch (5.92 KB, patch)
2022-03-28 15:20 PDT, Nikos Mouchtaris 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikos Mouchtaris
Comment 1 2022-03-25 22:49:31 PDT
Created attachment 455827 [details] Patch
Simon Fraser (smfr)
Comment 2 2022-03-28 15:17:46 PDT
Comment on attachment 455827 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455827&action=review > Source/WebCore/ChangeLog:8 > + Clamp nan, infinity and -infinity to zero for <angle>. Spec (or issue) link here please. > Source/WebCore/css/calc/CSSCalcValue.cpp:329 > + if (primitiveType() == CSSUnitType::CSS_DEG && (isnan(value) || isinf(value))) > + return 0; Are we always CSS_DEG here because of canonicalization, or can we end up here with CSS_RAD, CSS_GRAD etc?
Nikos Mouchtaris
Comment 3 2022-03-28 15:20:25 PDT
Created attachment 455962 [details] Patch
Nikos Mouchtaris
Comment 4 2022-03-28 15:21:20 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 455827 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=455827&action=review > > > Source/WebCore/ChangeLog:8 > > + Clamp nan, infinity and -infinity to zero for <angle>. > > Spec (or issue) link here please. Added GitHub issue link. > > > Source/WebCore/css/calc/CSSCalcValue.cpp:329 > > + if (primitiveType() == CSSUnitType::CSS_DEG && (isnan(value) || isinf(value))) > > + return 0; > > Are we always CSS_DEG here because of canonicalization, or can we end up > here with CSS_RAD, CSS_GRAD etc? Yes it will always be CSS_DEG due to canonicalization. Test covers this.
EWS
Comment 5 2022-03-28 18:17:42 PDT
Committed r292018 (248962@main): <https://commits.webkit.org/248962@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455962 [details].
Radar WebKit Bug Importer
Comment 6 2022-03-28 18:18:15 PDT
<rdar://problem/90957174>
Note You need to log in before you can comment on or make changes to this bug.