Bug 238398

Summary: [GTK][WPE] Support CSS accent-color
Product: WebKit Reporter: Alice Mikhaylenko <alicem>
Component: WebKitGTKAssignee: Alice Mikhaylenko <alicem>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mcatanzaro, pdr
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=246667
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch none

Alice Mikhaylenko
Reported 2022-03-25 16:27:57 PDT
See the patch.
Attachments
Patch (21.70 KB, patch)
2022-03-25 16:32 PDT, Alice Mikhaylenko 		no flags
DetailsFormatted DiffDiff
Patch (21.68 KB, patch)
2022-03-26 04:29 PDT, Alice Mikhaylenko 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (21.63 KB, patch)
2022-03-26 06:13 PDT, Alice Mikhaylenko 		no flags
DetailsFormatted DiffDiff
Patch (21.58 KB, patch)
2022-03-26 07:34 PDT, Alice Mikhaylenko 		no flags
DetailsFormatted DiffDiff
Patch (21.60 KB, patch)
2022-03-26 11:47 PDT, Alice Mikhaylenko 		no flags
DetailsFormatted DiffDiff
Patch (21.60 KB, patch)
2022-03-26 11:48 PDT, Alice Mikhaylenko 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Alice Mikhaylenko
Comment 1 2022-03-25 16:32:59 PDT
Created attachment 455809 [details] Patch
Alice Mikhaylenko
Comment 2 2022-03-25 16:36:19 PDT
> # accent-color is currently only supported on Cocoa platforms Oops, forgot to change this line. But I wonder if those tests actually pass...
Alice Mikhaylenko
Comment 3 2022-03-26 04:29:10 PDT
Created attachment 455840 [details] Patch
Alice Mikhaylenko
Comment 4 2022-03-26 06:13:23 PDT
Created attachment 455843 [details] Patch
Carlos Garcia Campos
Comment 5 2022-03-26 06:54:47 PDT
Comment on attachment 455843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455843&action=review > Source/WebCore/platform/adwaita/ThemeAdwaita.cpp:266 > + if (states.states().contains(ControlStates::States::Hovered) > + && states.states().contains(ControlStates::States::Enabled)) Use a single line here > Source/WebCore/platform/adwaita/ThemeAdwaita.cpp:298 > + if (states.states().contains(ControlStates::States::Hovered) > + && states.states().contains(ControlStates::States::Enabled)) Ditto. > Source/WebCore/platform/adwaita/ThemeAdwaita.cpp:350 > + if (states.states().contains(ControlStates::States::Hovered) > + && states.states().contains(ControlStates::States::Enabled)) Ditto. > Source/WebCore/platform/adwaita/ThemeAdwaita.cpp:367 > + if (states.states().contains(ControlStates::States::Hovered) > + && states.states().contains(ControlStates::States::Enabled)) Ditto.
Alice Mikhaylenko
Comment 6 2022-03-26 07:34:48 PDT
Created attachment 455848 [details] Patch
Michael Catanzaro
Comment 7 2022-03-26 08:33:33 PDT
r=me, but you'll have to write my name in the changelog manually. I can't use the r+ dropdown due to bug #238323.
Michael Catanzaro
Comment 8 2022-03-26 08:40:14 PDT
(In reply to Michael Catanzaro from comment #7) > r=me, but you'll have to write my name in the changelog manually. I can't > use the r+ dropdown due to bug #238323. I missed that you already got r+ from Carlos. Once you have r+, you don't have to request review again: you can either manually write in his name, or else download the patch using 'webkit-patch apply-from-bug' which will do so for you.
Alice Mikhaylenko
Comment 9 2022-03-26 11:47:32 PDT
Created attachment 455852 [details] Patch
Alice Mikhaylenko
Comment 10 2022-03-26 11:48:10 PDT
Err, I've manually written in the name and it still has r?. Let's try this again.
Alice Mikhaylenko
Comment 11 2022-03-26 11:48:30 PDT
Created attachment 455853 [details] Patch
Michael Catanzaro
Comment 12 2022-03-26 18:17:13 PDT
(In reply to Alexander Mikhaylenko from comment #10) > Err, I've manually written in the name and it still has r?. Let's try this > again. 'webkit-patch upload --no-review' works, or you could always just unset the flag yourself.
EWS
Comment 13 2022-03-27 04:54:48 PDT
Committed r291950 (248917@main): <https://commits.webkit.org/248917@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455853 [details].
Note You need to log in before you can comment on or make changes to this bug.